Skip to content

dont refetch data on activeChart change #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ItsEricSun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dont refetch data on activeChart change #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions apps/frontend/src/components/DonorStatsChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export function DonorStatsChart() {
const [isLoading, setIsLoading] = React.useState(false);
const [error, setError] = React.useState<string | null>(null);

// Fetch data whenever activeChart, quantity, or unit changes
// Fetch data whenever quantity or unit changes
React.useEffect(() => {
const fetchData = async () => {
setIsLoading(true);
Expand All @@ -181,12 +181,6 @@ export function DonorStatsChart() {

setDonationsData(donationsProcessed);
setRecurringDonorsData(recurringDonorsProcessed);

if (activeChart === 'donations') {
setChartData(donationsProcessed);
} else {
setChartData(recurringDonorsProcessed);
}
} catch (err) {
setError(err instanceof Error ? err.message : 'Failed to load data');
setChartData([]);
Expand All @@ -196,7 +190,7 @@ export function DonorStatsChart() {
};

fetchData();
}, [activeChart, quantity, unit]);
}, [quantity, unit]);

// Update chart data when activeChart changes
React.useEffect(() => {
Expand Down
Loading