Conversation
| @Column({ name: 'fulfilled_at', type: 'timestamp' }) | ||
| fulfilledAt: Date; | ||
| @Column({ name: 'fulfilled_at', type: 'timestamp', nullable: true }) | ||
| fulfilledAt?: Date | null; |
There was a problem hiding this comment.
Can these fields actually be undefined or null, or does it always come back one way or the other if the database column is null?
There was a problem hiding this comment.
Ah good point, the database always returns null I'm pretty sure. I think I can replace all these with ! since it will either be the value or null
| @IsNotEmpty({ each: true }) | ||
| @MaxLength(255, { each: true }) | ||
| restrictions?: string[]; | ||
| restrictions!: string[]; |
There was a problem hiding this comment.
What was the reason for this change?
There was a problem hiding this comment.
Correct me if I'm wrong but I think that this can not be undefined? Based on the pantry application form there need to be some selection of restrictions and in the DB restrictions is not nullable as well.
| "compilerOptions": { | ||
| "esModuleInterop": true | ||
| "esModuleInterop": true, | ||
| "strict": true |
There was a problem hiding this comment.
very epic and awesome line of code right here that I am very excited for !!
There was a problem hiding this comment.
I don't see any package.json changes?
3 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-131 and
https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-138
📝 Description
This PR enables typescript strict mode in the backend which enables the compiler to be a lot more picky and strict with types, null and undefined checks, etc. The PR includes changes to make our backend adhere with all the rules that strict mode enforces. This involved work making entity fields optional or required, and also handling null/undefined errors and return values.
✔️ Verification
I made sure all the backend tests pass and npx nx serve backend properly runs without error.
🏕️ (Optional) Future Work / Notes
N/A