Skip to content

chore: bump Go to 1.26.4 and update dependencies#219

Open
jlagedo wants to merge 1 commit into
Code-Hex:mainfrom
jlagedo:chore/bump-go-1.26-and-deps
Open

chore: bump Go to 1.26.4 and update dependencies#219
jlagedo wants to merge 1 commit into
Code-Hex:mainfrom
jlagedo:chore/bump-go-1.26-and-deps

Conversation

@jlagedo

@jlagedo jlagedo commented Jun 6, 2026

Copy link
Copy Markdown

Summary

Bumps the Go toolchain and dependencies to clear the stdlib and golang.org/x/crypto advisories reported by osv-scanner, and updates CI accordingly.

  • Go directive 1.24.01.26.4 in all modules (root + 3 examples). Clears the stdlib advisories osv-scanner flagged against the declared 1.24.0 version.
  • golang.org/x/crypto 0.46.0 → 0.52.0 (x/sys 0.39.0 → 0.45.0 via tidy). Clears GO-2026-5013/5017/5018/5019/5020. This is a test-only dependency (imported only in virtualization_test.go and internal/testhelper/ssh.go; go mod why reports the main module doesn't need it), bumped for downstream scanner hygiene.
  • 4 go vet printf fixes (bufbuf.String()) in shared_directory_test.go and socket_test.go. These were latent (%q on a bytes.Buffer value) and are surfaced by the stricter printf analyzer once the go directive is raised; without the fix go vet ./... fails CI.
  • CI matrix (build + test jobs) updated to ^1.26.

Verification

Run locally on macOS arm64 with go1.26.4:

  • go vet ./... — clean
  • go build ./... — library + all 3 example modules build
  • Codesigned VM integration suite (go test -exec "go run cmd/codesign" .) — passes, boots real Linux guests

Notes

  • Go 1.26 is the last release supporting macOS 12; this keeps macOS 12 host support (1.27 would drop it).

🤖 Generated with Claude Code

- Bump go directive 1.24.0 -> 1.26.4 in all modules (root + 3 examples),
  clearing the stdlib advisories flagged by osv-scanner for 1.24.0.
- Bump golang.org/x/crypto 0.46.0 -> 0.52.0 (x/sys 0.39.0 -> 0.45.0 via
  tidy), clearing GO-2026-5013/5017/5018/5019/5020. Test-only dependency,
  but bumped for downstream scanner hygiene.
- Fix 4 printf vet errors (buf -> buf.String()) surfaced by the stricter
  printf analyzer at the new go directive, in shared_directory_test.go and
  socket_test.go.
- Update CI matrix (build + test jobs) to ^1.26.

Verified: go vet ./... clean, library + all 3 example modules build, and
the codesigned VM integration suite passes (boots real Linux guests).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment thread go.mod
module github.com/Code-Hex/vz/v3

go 1.24.0
go 1.26.4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forces anyone who wants to use Code-Hex/vz to switch to go 1.26.4 or newer, which can be complicated in some cases (eg IT controlled environment, …).
Imo it’s up to the modules using Code-Hex/vz to ensure they are using up to date go versions with no known vulnerability rather than Code-Hex/vz forcing them to do so. If Code-Hex/vz starts doing this, this means it will have to constantly update go 1.26.4 to the latest version.
I’d stick to 1.25.0 for this line as 1.25 is still supported (but you have to use latest 1.25 when building)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a nice question to be decided, my daily work is in a high regulated it env and everyone is pushing closing cves to the max, but its really something that needs feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants