MudSignaturePad ClearPad Public#596
Conversation
|
Thanks for the PR. Could you also change other async Task methods to the public? If you need to programmatic clear, i think someone other wants to programmatic download or upload etc. |
|
I’ve made IsEditToggled and Download public. As far as I can tell, there’s no upload functionality in this component — unless I missed something..? I’ve limited the changes to these three methods. I don’t believe the other private async task needs to be made public, but let me know if you think it should be exposed as well. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #596 +/- ##
=======================================
Coverage 67.98% 67.98%
=======================================
Files 105 105
Lines 7408 7408
Branches 1275 1275
=======================================
Hits 5036 5036
Misses 1899 1899
Partials 473 473 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks 🥇 |
Making ClearPad of MudSignaturePad a public method.
Our use case :
On a small device, having a signature pad in a modal, we remove entirely the toolbar to get the space available. And we had a button to clear the pad in the DialogActions (along with OK and cancel).
This allows us to get all the space we can for the signture pad