Skip to content

MudSignaturePad ClearPad Public#596

Merged
mckaragoz merged 2 commits intoCodeBeamOrg:devfrom
1zerro1:dev
Feb 11, 2026
Merged

MudSignaturePad ClearPad Public#596
mckaragoz merged 2 commits intoCodeBeamOrg:devfrom
1zerro1:dev

Conversation

@1zerro1
Copy link
Contributor

@1zerro1 1zerro1 commented Feb 6, 2026

Making ClearPad of MudSignaturePad a public method.

Our use case :
On a small device, having a signature pad in a modal, we remove entirely the toolbar to get the space available. And we had a button to clear the pad in the DialogActions (along with OK and cancel).

This allows us to get all the space we can for the signture pad

@mckaragoz
Copy link
Contributor

Thanks for the PR. Could you also change other async Task methods to the public? If you need to programmatic clear, i think someone other wants to programmatic download or upload etc.

@1zerro1
Copy link
Contributor Author

1zerro1 commented Feb 9, 2026

I’ve made IsEditToggled and Download public.

As far as I can tell, there’s no upload functionality in this component — unless I missed something..?

I’ve limited the changes to these three methods. I don’t believe the other private async task needs to be made public, but let me know if you think it should be exposed as well.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.98%. Comparing base (71b49a0) to head (91f45e4).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...s/Components/SignaturePad/MudSignaturePad.razor.cs 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #596   +/-   ##
=======================================
  Coverage   67.98%   67.98%           
=======================================
  Files         105      105           
  Lines        7408     7408           
  Branches     1275     1275           
=======================================
  Hits         5036     5036           
  Misses       1899     1899           
  Partials      473      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mckaragoz mckaragoz merged commit c6fe46b into CodeBeamOrg:dev Feb 11, 2026
2 of 3 checks passed
@mckaragoz
Copy link
Contributor

Thanks 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants