fix: align PR reviews with the main analysis configuration - #7
Merged
Merged
Conversation
Replace the temporary Action PR 120 ref with the same released action used by sync, and keep both workflows at depth 2. The old engine and depth 3 created a different base graph for the same merge-base commit. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0d63c-1b35-732f-bd08-a0ec57f0bff3
CodeBoarding reviewStatus: 0 changed components See the full change in CodeBoarding. graph LR
n_Client_App["Client App"]
n_Ordering_Service["Ordering Service"]
n_Identity_API["Identity API"]
n_Web_Frontends["Web Frontends"]
n_Catalog_Service["Catalog Service"]
n_Webhooks_and_Shared_Infrastructure["Webhooks and Shared Infrastructure"]
n_Event_Bus["Event Bus"]
n_Basket_API["Basket API"]
n_Application_Host_and_Defaults["Application Host and Defaults"]
n_Payment_Processor["Payment Processor"]
n_Payment_Processor -- "publishes events to" --> n_Event_Bus
n_Ordering_Service -- "stores outbox events in" --> n_Catalog_Service
n_Ordering_Service -- "uses migration helpers in" --> n_Webhooks_and_Shared_Infrastructure
n_Ordering_Service -- "publishes and subscribes events via" --> n_Event_Bus
n_Ordering_Service -- "configures defaults from" --> n_Application_Host_and_Defaults
n_Web_Frontends -- "subscribes to events on" --> n_Event_Bus
n_Web_Frontends -- "configures HTTP and config defaults from" --> n_Application_Host_and_Defaults
n_Catalog_Service -- "uses migration helpers in" --> n_Webhooks_and_Shared_Infrastructure
n_Catalog_Service -- "publishes and subscribes events via" --> n_Event_Bus
n_Webhooks_and_Shared_Infrastructure -- "subscribes to events on" --> n_Event_Bus
n_Webhooks_and_Shared_Infrastructure -- "configures authentication defaults from" --> n_Application_Host_and_Defaults
n_Event_Bus -- "dispatches events to" --> n_Payment_Processor
n_Event_Bus -- "dispatches events to" --> n_Ordering_Service
n_Event_Bus -- "dispatches events to" --> n_Web_Frontends
n_Event_Bus -- "dispatches events to" --> n_Catalog_Service
n_Event_Bus -- "dispatches events to" --> n_Webhooks_and_Shared_Infrastructure
n_Event_Bus -- "dispatches events to" --> n_Basket_API
n_Basket_API -- "subscribes to events on" --> n_Event_Bus
n_Basket_API -- "configures defaults from" --> n_Application_Host_and_Defaults
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Reviews #5 and #6 are based on current main, but their workflows generate a different architecture for that same commit:
@v10.14.4@refs/pull/120/head0.14.1The PR-head pin was left over from testing Action PR dotnet#120. The Action correctly isolates cached state by engine/configuration. Review #5 therefore missed the sync artifact, rejected the committed depth-2 baseline as incompatible, and generated a new depth-3 baseline. Review #6 reused that alternate baseline. Rebasing does not change either workflow setting.
This is an eShop workflow configuration bug, not a webview rendering or merge-base selection bug. The production webview API returns exactly the base/head JSON in the Action artifacts.
Reproduction established before the fix
Basket APIandCatalog Service.Ordering,Webhooks, andLoose files in src.WebApp. The GitHub comment shows the same alternate graph.gh api repos/CodeBoarding/eShop/compare/main...c068b520e50a4cca2ab0369f1bc77a63cc64bb3ereportsbehind_by: 0, and its merge base is the current main baseline commit. Review metadata records that same commit.codeboarding-base-8595c58016359d69-<merge-base>, runs full baseline analysis at depth 3, and publishes base artifact10783925749. PR feat: validate basket products against Catalog — architecture impact demo #6's metadata points to that exact ID.10782827140, namedcodeboarding-base-fad27b0797f73921-<merge-base>. Both describe the same source-tree hash, but their graphs differ. The sync artifact'sanalysis.jsonis byte-for-byte identical to committed main; the review baseline is not.To reproduce from scratch, sync a repository with engine 0.14.4/depth 2, branch from that synced commit, and review it with the old PR-120 ref/depth 3. The first review generates an alternate base; subsequent reviews reuse it, even after rebasing onto main.
Fix
Use
@v1,llm: hosted, and explicitdepth_cap: 2in both workflows. Keep the existing merge-base comparison behavior and main analysis unchanged.Verification
@v1scripts.git diff --checkpassed.10782827140. The production API'sbaseDataequals committed main's entire parsed JSON. No full baseline regeneration occurred.Basket APIandCatalog Service. The old PR feat: validate basket products against Catalog — architecture impact demo #6 still reproduces the 8-component graph.Existing reviews
This PR does not merge itself or rewrite saved artifacts. After merging, update PRs #5/#6 to include the corrected workflow and let new review runs complete. Re-running an old workflow run uses its old workflow revision and is not a repair. Previously saved run-specific URLs will continue to show their historical analyses; the unpinned PR URLs select the latest run.