Correctly Set Up EditorManager on New Workspaces#2114
Merged
thecoolwinter merged 2 commits intoCodeEditApp:mainfrom Aug 26, 2025
Merged
Correctly Set Up EditorManager on New Workspaces#2114thecoolwinter merged 2 commits intoCodeEditApp:mainfrom
thecoolwinter merged 2 commits intoCodeEditApp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjusts the setup of EditorManager to always assign the
workspaceproperty on all editors after restoring it. This creates duplicate work when we have editors that successfully restore from a saved state, but ensures we always set up the editor manager correctly even when an error is thrown or there is no restoration data.Adjusted UI tests to catch this.
Related Issues
Checklist
Screenshots
N/A