Fix: Status bar not updating when workspace first opens#2161
Open
William-Laverty wants to merge 1 commit intoCodeEditApp:mainfrom
Open
Fix: Status bar not updating when workspace first opens#2161William-Laverty wants to merge 1 commit intoCodeEditApp:mainfrom
William-Laverty wants to merge 1 commit intoCodeEditApp:mainfrom
Conversation
…1729) The status bar's Line/Col information wasn't appearing until the first tab switch because tabBarTabIdSubject (a PassthroughSubject) only emitted values when selectedTab CHANGED, not its initial value. Fixed by: 1. Sending the current selectedTab value immediately in switchToActiveEditor() 2. Using dropFirst() on the publisher subscription to avoid duplicate emissions This ensures subscribers like StatusBarCursorPositionLabel receive the initial tab state when the workspace loads. Fixes CodeEditApp#1729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the status bar's Line/Col information not appearing until the first tab switch after opening a workspace.
Problem
The
tabBarTabIdSubjectis aPassthroughSubject, which only emits values to subscribers when itssend()method is called AFTER the subscription is created. When a workspace first opens:StatusBarCursorPositionLabel.onAppearfires and callsupdateSource()updateSource()readseditorManager.activeEditor.selectedTab(may be nil during loading)tabBarTabIdSubject.onReceiveis subscribed but no initial value is emittedSolution
Modified
switchToActiveEditor()to:selectedTabvalue immediately when setting up the subscriptiondropFirst()on the publisher to avoid duplicate emissionsThis ensures all subscribers receive the initial tab state when the workspace loads.
Testing
Fixes #1729