Add Bold and Italics Support To Themes#289
Merged
thecoolwinter merged 6 commits intoCodeEditApp:mainfrom Jan 11, 2025
Merged
Conversation
Collaborator
|
Make sure to compare with Xcode. The weights look a little light to me at first glance. Standard weight should be Medium |
Collaborator
Author
|
You're right it does seem a little light. The example app was using |
Collaborator
Author
|
@austincondiff How does this look to you? |
Collaborator
|
I think so. It's difficult to tell because the strings are also italicized. Can you instead post a screenshot with keywords in bold? |
Collaborator
Author
Uh oh they were bolded, I think they need to go one weight higher then. |
Collaborator
Author
austincondiff
approved these changes
Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Warning
This is a API-breaking change, merging this will require a minor version update when releasing.
Related Issues
Checklist
Screenshots
Update example app default theme with bold and italics on strings, italics on comments, and bold on keywords.
Screen.Recording.2025-01-10.at.2.53.13.PM.mov