fix(transport-websocket): build against @types/bun 1.4 - #396
Merged
Merged
Conversation
@types/bun 1.4 adds a mutable subscriptions array to ServerWebSocket, so the deep-readonly socket Bun hands to the handlers no longer fits a mutable field. The client state only sends on and closes the socket. Keeps the lockfile's configVersion line, which the pinned Bun writes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries Renovate's type updates from #374 (
@types/bun1.3.1 to 1.4.2 and@types/node) with the fix that lets them build. Renovate should close #374 once this merges.@types/bun1.4 adds a mutablesubscriptions: string[]toServerWebSocket. The websocket server receives the socket asReadonlyDeepand stored it in a field typed as the mutable socket, which now fails with TS2375 underexactOptionalPropertyTypes. The internal client state now stores the socket asReadonlyDeeptoo. It only callssendandcloseon it, so nothing else changes.The lockfile keeps the
configVersionline that Renovate's Bun dropped, because the repo's pinned Bun writes it.