136 reset document form btn v2 - #175
Open
stanislawK wants to merge 9 commits into
Open
Conversation
Rafalkufel
approved these changes
Oct 21, 2025
Comment on lines
+64
to
+72
| self.populate_application_reason(application_subject) | ||
|
|
||
| def populate_application_subject(self) -> None: | ||
| for issue, description in ISSUE_DESCRIPTION_NOMINATIVE_MAPPER.items(): | ||
| self.application_subject.combobox.addItem(description, issue) | ||
|
|
||
| def populate_application_reason(self, application_subject: LabeledComboBoxComponent | None = None) -> None: | ||
| if not application_subject: | ||
| application_subject = self.application_subject.combobox.currentData() |
| @@ -0,0 +1,352 @@ | |||
| import os | |||
Contributor
There was a problem hiding this comment.
Very first test of our widget! 🎆
Rafalkufel
approved these changes
Oct 21, 2025
| def __init__(self, parent: QWidget, visible: bool = False): | ||
| super().__init__(parent) | ||
| self.footer_container = parent | ||
| self.content_container = self.footer_container.main_body_container.content_container |
Contributor
There was a problem hiding this comment.
Do you really need to have self.content_container? Maybe you can move it to clear_application
def clear_application(self):
content_container = self.footer_container.main_body_container.content_container
content_container.application_container.clear()
Contributor
Author
|
Pcks are available for testing in https://github.com/stanislawK/alinka-pyside/actions/runs/18808039156 |
Contributor
Author
|
To make that change in line with a new style, I removed red color and added pop-up window instead. I am not sure about the wording. |
Rafalkufel
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #136
Original discussion and screenshots in PR created by pushing directly to alinka repo #139. That is the version pushed from the fork