London 10 - Pouya Nasraei Ghomi - JavaScript-Core-1-Coursework-Week1#530
London 10 - Pouya Nasraei Ghomi - JavaScript-Core-1-Coursework-Week1#53085pouya wants to merge 2 commits intoCodeYourFuture:masterfrom
Conversation
|
👋 Hi there @85pouya . Please update your PR title to follow the format requested. If you take a look at https://github.com/CodeYourFuture/JavaScript-Core-1-Coursework-Week1/pulls you will see how everyone else is doing it. Thanks! |
85pouya
changed the title
hi, I just updated the PR title @SallyMcGrath |
|
|
||
| return "The total is total"; | ||
| return `The total is ${total}`; | ||
| } |
There was a problem hiding this comment.
Hi Pouya, Good job! You forgot to create a variable into your function. I mean, try to add 'const' or 'let' before the word 'total'.
Thanks!
There was a problem hiding this comment.
Thank you @Ali-Jahankah for your feedback. I added 'let' before 'total'
| return(multiply); | ||
| } | ||
|
|
||
| /* |
| let taxprice = price + price*0.2; | ||
| return taxprice = '£' + taxprice.toFixed(2); | ||
| } | ||
|
|
There was a problem hiding this comment.
Everything is fine. You can call 'calculateSalesTax' instead of rewriting the codes again. We call this 'DRY coding'. Your current way is fine, too.
I added let to assign total as the sum of a and b.
4 participants
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?