LND10 | Adrian Ilovan | JS1 Coursework Week1#541
LND10 | Adrian Ilovan | JS1 Coursework Week1#541AdrianIlovan wants to merge 4 commits intoCodeYourFuture:masterfrom
Conversation
|
Morning @AdrianIlovan 🌞 ☕ , |
| // There are syntax errors in this code - can you fix it to pass the tests? | ||
|
|
||
| function addNumbers(a b c) { | ||
| function addNumbers(a ,b ,c) { |
There was a problem hiding this comment.
are you using prettier formatter to format your code on save? I recommend it, as it will fix issues like this where the space should be after the comma not before
| } | ||
|
|
||
| function concatenate(firstWord, secondWord, thirdWord) { | ||
| return firstWord.concat(" ", secondWord.concat(" ", thirdWord)); |
There was a problem hiding this comment.
you can also add all arguments into the .concat() method call, e.g.
return firstWord.concat(" ", secondWord, " ", thirdWord);
| let total = a + b; | ||
|
|
||
| return "The total is total"; | ||
| return `The total is ${total}`; |
|
|
||
| function calculateSalesTax() {} | ||
| function calculateSalesTax(number) { | ||
| let priceOfProduct = number * 1.2; |
There was a problem hiding this comment.
you could use a variable name for the number 1.2 so it's more meaningful, e.g.
const totalPlusTax = 1.2;
let priceOfProduct = number * totalPlusTax;
return priceOfProduct;
|
|
||
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(pound) { | ||
| pound = calculateSalesTax(pound); |
There was a problem hiding this comment.
It's better practice to declare a new variable, rather than reassign the value of a parameter, e.g.
const priceWithTax = calculateSalesTax(pound);
| function addTaxAndFormatCurrency() {} | ||
| function addTaxAndFormatCurrency(pound) { | ||
| pound = calculateSalesTax(pound); | ||
| return `£${pound.toFixed(2)}`; |
There was a problem hiding this comment.
👍 very nice use of .toFixed() and string interpolation
| @@ -1,14 +1,15 @@ | |||
| // Add comments to explain what this function does. You're meant to use Google! | |||
| // It generates a random number using Math.random() and it multiplies by 10 | |||
There was a problem hiding this comment.
Math.random() returns a number greater than or equal to 0 and less than 1, so this returns a number greater than or equal to 0 and less than 10
AdrianIlovan
changed the title
3 participants
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?