This repository was archived by the owner on Jan 14, 2024. It is now read-only.
London10-StellaDelMar_RodriguezFernandez-JavaScript-Core-1-Coursework-Week1#546
Open
Stelladelmar wants to merge 2 commits intoCodeYourFuture:masterfrom
Open
London10-StellaDelMar_RodriguezFernandez-JavaScript-Core-1-Coursework-Week1#546Stelladelmar wants to merge 2 commits intoCodeYourFuture:masterfrom
Stelladelmar wants to merge 2 commits intoCodeYourFuture:masterfrom
Conversation
| function introduceMe(name, age) { | ||
| return `Hello, my name is ${name} and I am ${age} years old`; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Small comment on this one - whenever you are declaring a new variable, it's a good idea to use let or const.
| @@ -1,16 +1,17 @@ | |||
| // There are syntax errors in this code - can you fix it to pass the tests? | |||
|
|
|||
Contributor
There was a problem hiding this comment.
These look good to me 👍
| @@ -1,16 +1,16 @@ | |||
| // The syntax for these functions is valid but there are some errors, find them and fix them | |||
|
|
|||
Contributor
There was a problem hiding this comment.
These all look perfect to me 👍
| @@ -5,7 +5,10 @@ | |||
| Sales tax is 20% of the price of the product. | |||
| */ | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Great job on these exercises 👍
| @@ -5,7 +5,11 @@ function getRandomNumber() { | |||
|
|
|||
Contributor
There was a problem hiding this comment.
It's worth attempting these if you get some time.
It's perfectly fine to Google something like this. We could start by searching for something like "javascript join strings together".
Contributor
|
Nice attempt on this coursework @Stelladelmar! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?