London | ITP-May-2025 | Seddiq Azam | Module-Data-Flows | Book Library by sedazam · Pull Request #263 · CodeYourFuture/Module-Data-Flows

sedazam · 2025-08-03T09:39:13Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

📋 Summary

This PR improves form validation, enhances core library functionality, and fixes several bugs to ensure smoother user interaction and better data handling.

✅ Form Validation Improvements

Added strict empty-field checks for Title, Author, and Pages.
Used .trim() to prevent whitespace-only submissions.
Validated Pages input to accept only positive integers.
Improved error messaging for clearer, more user-friendly feedback.

🎯 Core Functionality Fixes

Completed render() to display books in a properly formatted table.
Fixed Delete button functionality with correct array index handling and confirmation prompts.
Added toggle read status with dynamic button styles and state management.
Implemented viewReadBooks() to filter and show only books marked as read.

🐛 Bug Fixes

Fixed table row insertion order (books now display in the correct order).
Resolved array index issues when deleting books.
Corrected type handling for Pages (string → number).
Fixed form submission event handling to prevent unintended page reloads.

Questions

Ask any questions you have for your reviewer.

… debugging

…on in submit function

…brary

…y interface

…library interface; update CSS for better button alignment

…improve readability

…ook is marked as read

…rary interface

…adability and efficiency

…ays an integer

…a valid number

cjyuan

Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md

Doing so can help me speed up the review process. Thanks.

…submission form

…tructure

…oks function

…ion in viewReadBooks

…erience

…oved user experience and accessibility

…label attributes

…nd update createDeleteButton for improved functionality and accessibility

…lity and maintainability; enhance accessibility features for buttons and forms

…and efficiency; remove redundant code for resetting input fields

…; ensure proper form attributes are set

sedazam · 2025-08-13T13:58:28Z

This update fixes all the original bugs.
Books now display correctly when the page loads, titles and authors are handled properly, read status is saved accurately, and the delete button works as expected.

On top of that, I went beyond the requirements by improving form validation.
This includes trimming whitespace, enforcing positive numbers for page counts, and preventing incomplete submissions.
I also added clear alerts for both errors and successes so users get immediate feedback.

New features include a dynamic toggle for read status with instant visual updates and a viewReadBooks() filter to quickly show only completed books.
Overall, the library is now faster, cleaner, and much easier to use.

cjyuan

Changes look good.

Sorry that I don't have time to go over the extra features you have implemented.

cjyuan · 2025-08-13T15:00:37Z

debugging/book-library/script.js

-    library.push(book);
-    render();
+function addBook() {
+  console.log("Add book button clicked!");


It is a best practice, when submitting code for review, to remove all non-essential code (including that used for debugging) to keep the codebase clean.

Removed the console.log

I want to thank you for all your effort, reviews, and valuable suggestions about the code.

github-actions · 2025-08-14T10:29:23Z

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Module-Data-Flows) doesn't match expected format (example: 'Sprint 2', without quotes)

sedazam added 24 commits August 2, 2025 07:58

Fix input types in book library form and add launch configuration for…

a3bdf48

… debugging

Fix input types for title and author fields in book library form

ae05097

Fix syntax error in render function loop

abfc0a3

Fix read status logic in render function

1573031

Fix reference to myLibrary in submit function

9440f65

Fix delete button functionality in render function

51aa207

Fix book constructor parameters in submit function

ed8d683

Fix author parameter in book constructor in submit function

2d6fdc2

Fix validation logic in submit function to check author field

3b0639a

Add buttons for viewing read books and all books; fix author validati…

75eea9c

…on in submit function

Add viewReadBooks function to filter and display read books in the li…

a1e10b5

…brary

Refactor button layout for better structure and styling in the librar…

5a823b1

…y interface

Refactor button layout for improved accessibility and styling in the …

e4ab05e

…library interface; update CSS for better button alignment

Update render function to simplify cell insertion for read books and …

7f237b1

…improve readability

Fix submit function to ensure viewReadBooks is called only when the b…

2ce428b

…ook is marked as read

Clear input fields after submitting a new book

cb72564

Refactor button group for consistent styling and alignment in the lib…

9dd36cb

…rary interface

Refactor viewReadBooks function to utilize clearTable for improved re…

4858f47

…adability and efficiency

Refactor submit and render functions for improved clarity and efficiency

a4d5f61

Refactor submit function to improve input validation and clarity

fa3eb54

Refactor button creation in render function for consistency and clarity

8b38508

Fix typo in book title in populateStorage function

2747277

Fix pages property assignment in Book constructor to ensure it is alw…

9ec60d1

…ays an integer

Enhance input validation in submit function to ensure pages value is …

4996041

…a valid number

sedazam added 📅 Data Flows Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module labels Aug 3, 2025

Delete .vscode/launch.json

dd0296b

cjyuan reviewed Aug 8, 2025

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 8, 2025

sedazam added 20 commits August 12, 2025 12:24

Add title to HTML document for better context

a3af05a

Fix formatting of meta tags in HTML for consistency

f5f4992

Remove empty table row in book display for cleaner presentation

0232a7c

Improve checkbox label for clarity in book submission form

340a5b9

Replace submit input with button for better user interaction in book …

5ba4b53

…submission form

Add header for actions column in book display table

10fe990

Fix row insertion in render function to use tbody for correct table s…

80d8249

…tructure

Add buttons for toggling read status and deleting books in viewReadBo…

9e63739

…oks function

Enhance read status button functionality and improve delete confirmat…

f3427a1

…ion in viewReadBooks

Refactor book submission form for improved accessibility and user exp…

1db3d2a

…erience

Refactor HTML structure and enhance JavaScript functionality for impr…

7fcf6fc

…oved user experience and accessibility

Add title attribute to delete button for improved accessibility

2c17c9a

Add aria-label to delete button for improved accessibility

b1bde3e

Enhance accessibility of read status button by adding title and aria-…

a5bb00a

…label attributes

Refactor deleteBook function to accept title and author parameters, a…

02416c5

…nd update createDeleteButton for improved functionality and accessibility

Refactor HTML structure and JavaScript functions for improved readabi…

0950066

…lity and maintainability; enhance accessibility features for buttons and forms

Update initial book data in populateStorage function

7129071

Refactor clearForm function to use form.reset() for improved clarity …

92c6565

…and efficiency; remove redundant code for resetting input fields

Add event listener to book form for submission handling

676a5e2

Refactor book form structure for improved semantics and accessibility…

d310f39

…; ensure proper form attributes are set

sedazam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 13, 2025

cjyuan reviewed Aug 13, 2025

View reviewed changes

Remove console log for add book button click to clean up code

37b98ed

illicitonion removed the 📅 Data Flows label Aug 14, 2025

illicitonion closed this Sep 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

London | ITP-May-2025 | Seddiq Azam | Module-Data-Flows | Book Library#263

London | ITP-May-2025 | Seddiq Azam | Module-Data-Flows | Book Library#263
sedazam wants to merge 59 commits intoCodeYourFuture:mainfrom
sedazam:book-library

sedazam commented Aug 3, 2025 •

edited

Loading

Uh oh!

cjyuan left a comment •

edited

Loading

Uh oh!

sedazam commented Aug 13, 2025

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Aug 13, 2025

Uh oh!

sedazam Aug 13, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sedazam commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

📋 Summary

✅ Form Validation Improvements

🎯 Core Functionality Fixes

🐛 Bug Fixes

Questions

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sedazam commented Aug 13, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

sedazam Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sedazam commented Aug 3, 2025 •

edited

Loading

cjyuan left a comment •

edited

Loading