London | 25-ITP-May | Halimatou Saddiyaa | Sprint 3 | Programmer humour

[Halimatou-saddiyaa]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

I've implemented a programmer humour app with the following requirements:

• The program gets the json using Fetch.
• The function should make an API call to the given endpoint: https://xkcd.now.sh/?comic=latest
• It should log the received data to the console
• It should render the img property into an tag in the DOM
• It should Incorporate error handling

Please review my PR.

Questions

Ask any questions you have for your reviewer.

[LonMcGregor]

Good work on this - the code and html works great. If you want to push yourself further, I've left a little remark about the styling

[LonMcGregor]

Very minor issue: Be careful when using height and padding - on some devices this causes scrollbars which are unnecessary for the size of this webpage.

[Halimatou-saddiyaa]

I've modified min-height to use dynamic viewport height(dvh) to avoid unnecessary scroll and use box-sizing: border-box to prevent padding increasing the overall height.

[Halimatou-saddiyaa]

Thanks for reviewing my PR @LonMcGregor . I've made the necessary changes, can you please check again?

[github-actions]

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[LonMcGregor]

Good work - you are done with this sprint

[github-actions]

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).