London | 25-ITP-May | Khilola Rustamova |Sprint 2| book library#310
London | 25-ITP-May | Khilola Rustamova |Sprint 2| book library#310HilolaRustam wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes) |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes) |
HilolaRustam
added
📅 Sprint 2
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes) |
5 similar comments
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes) |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes) |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes) |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes) |
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (SPRINT 2) doesn't match expected format (example: 'Sprint 2', without quotes) |
HilolaRustam
changed the title
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
HilolaRustam
added
📅 Sprint 1
| alert("Please fill all fields correctly!"); | ||
| return; | ||
| } | ||
| let book = new Book(title, author, Number(pages), readCheckBox.checked); |
There was a problem hiding this comment.
pages could be a string resembling a number with decimal places.
| if(confirm(`Are you sure you want to delete " ${myLibrary[i].title}"?`)){ | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Why not use the VSCode extension 'prettier' to auto indent JS code?
cjyuan
added
Complete
3 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.