London | 25-ITP-May | Houssam Lahlah | Sprint 2 | feature/book library#313
Closed
HoussamLh wants to merge 2 commits intoCodeYourFuture:mainfrom
Closed
London | 25-ITP-May | Houssam Lahlah | Sprint 2 | feature/book library#313HoussamLh wants to merge 2 commits intoCodeYourFuture:mainfrom
HoussamLh wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
- change library.push(book) to myLibrary.push(book). - add a ) to the end of the for loop condition to avoid syntax error. - change myLibrary[i].check to myLibrary[i].check == true to check if the book is read or not. - change delBut to delButton because we declare it. - The event listener is "clicks" instead of "click".
HoussamLh
added
the
Needs Review
sambabib
added
Review in progress
sambabib
reviewed
Aug 19, 2025
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| //fix: change title.value to author.value | ||
| let book = new Book(title.value, author.value, pages.value, check.checked); |
sambabib
reviewed
Aug 19, 2025
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| // Fix : add a ) to the end of the for loop condition | ||
| // to avoid syntax error. | ||
| for (let n = rowsNumber - 1; n > 0; n--) { |
There was a problem hiding this comment.
Good catch of the syntax error here as well.
sambabib
reviewed
Aug 19, 2025
| @@ -76,7 +80,9 @@ function render() { | |||
| changeBut.className = "btn btn-success"; | |||
There was a problem hiding this comment.
Whilst this isn’t a bad variable name, it is good practice to have clear variable names so the purpose can be inferred at a quick glance. For example, changeButton would have been better here. Something to note moving forward.
sambabib
reviewed
Aug 19, 2025
| // Fix: change myLibrary[i].check to myLibrary[i].check == true | ||
| // to check if the book is read or not. | ||
| if (myLibrary[i].check == true) { | ||
| readStatus = "Yes"; |
There was a problem hiding this comment.
When you build applications with status updates, it is good practice to store these statuses in variables/objects. For a small application like this, it is not necessary but as your codebase grows bigger, it becomes easier to slot in the status variable than constantly type in a string (typos could happen). This is something to note.
sambabib
reviewed
Aug 19, 2025
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| delButton.id = i + 5; |
There was a problem hiding this comment.
See. You used a better variable name here, so try to keep it consistent.
sambabib
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
## Changelist
Fixed issue where books did not display on page load
Corrected bug where title was being used as author when adding new books
Fixed delete button (wrong variable name + wrong event type)
Corrected read/unread toggle so it shows the correct value
Cleaned up table rendering loop to properly remove old rows
Minor syntax corrections (missing bracket in for loop)
## Questions
Is my render() function written in a clean way, or should I break it into smaller functions?
Would you recommend converting the Book constructor into a class for better readability?