Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 3 | Programmer Humour

[KhotKeys]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Learnt about fetch and the DOM, specifically:

• used fetch to make an API call to the xkcd endpoint and rendered the comic image into the DOM.

[hey-hammad]

Good implementation overall. I have a few suggestions around DOM element checks, avoiding repeated DOM queries. Thanks

[hey-hammad]

would it be better to if we cache the comic-img element instead of querying the DOM twice? It would make the code a bit cleaner and avoid repeating the selector.

[hey-hammad]

Also can we assume that elements comic-img and error are always available, and the absence will not break the code?

[KhotKeys]

would it be better to if we cache the comic-img element instead of querying the DOM twice? It would make the code a bit cleaner and avoid repeating the selector.

All changes are fully fixed, thanks for the feedback