Skip to content

London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 3 | Programmer Humour - #547

Open
khaliun-dev wants to merge 1 commit into
CodeYourFuture:mainfrom
khaliun-dev:sprint-3/feature/xkcd
Open

London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 3 | Programmer Humour#547
khaliun-dev wants to merge 1 commit into
CodeYourFuture:mainfrom
khaliun-dev:sprint-3/feature/xkcd

Conversation

@khaliun-dev

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have learnt how to consume an API with JavaScript's Fetch API, process the JSON response, and dynamically render the returned image in the DOM with error handling.

Questions

None.

@khaliun-dev khaliun-dev added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Aug 13, 2026
@hey-hammad hey-hammad added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 21, 2026

@hey-hammad hey-hammad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work overall. There are just a few areas where we could improve robustness, such as not assuming that DOM elements are always present, validating the API response, and providing feedback to users when something goes wrong. Thanks

@hey-hammad hey-hammad added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Data-Flows The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants