Skip to content

Glasgow | 26-ITP-May | Tuan Nguyen | Sprint 2 | Book-Library-Project #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jacknguyen4438 wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Glasgow | 26-ITP-May | Tuan Nguyen | Sprint 2 | Book-Library-Project #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
580571e
adding missing parenthesis at line 57
Jacknguyen4438 Aug 15, 2026
1c3aa67
Fixed issues in the submit() function that prevented new books from b…
Jacknguyen4438 Aug 15, 2026
c9da8fd
Corrected the read/unread display logic and fixed the broken delete b…
Jacknguyen4438 Aug 15, 2026
dd59bc5
Making error fix based from HTML validation checker
Jacknguyen4438 Aug 15, 2026
73bab0a
Making change on HTML and JS code after validation check
Jacknguyen4438 Aug 16, 2026
0d58a53
Fix review comments #3 and #6
Jacknguyen4438 Aug 17, 2026
39ec810
Fix review comments #5 and #7:
Jacknguyen4438 Aug 17, 2026
24896a1
Fix review comments #2 and #8:
Jacknguyen4438 Aug 17, 2026
398359f
Fix review comments #1, #4 and #9:
Jacknguyen4438 Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
147 changes: 59 additions & 88 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,67 @@
<!DOCTYPE html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<html lang="en">

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
<head>
<title>Online Book Library</title>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" />

<link rel="stylesheet" href="style.css" />
</head>

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>

<div id="demo" class="collapse">
<form class="form-group" id="book-form">
<label for="title">Title:</label>
<input type="text" class="form-control" id="title" name="title" required />

<label for="author">Author:</label>
<input type="text" class="form-control" id="author" name="author" required />

<label for="pages">Pages:</label>
<input type="number" class="form-control" id="pages" name="pages" min="1" step="1" required />

<div class="form-check">
<input type="checkbox" class="form-check-input" id="check" />
<label class="form-check-label" for="check">
Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
</div>
</div>
<input type="submit" value="Submit" class="btn btn-primary" />
</form>
</div>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>

<tbody id="book-list"></tbody>
</table>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>
<script src="script.js"></script>
</body>

<script src="script.js"></script>
</body>
</html>
</html>
146 changes: 81 additions & 65 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,64 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const readCheckbox = document.getElementById("check");

const bookForm = document.getElementById("book-form");

bookForm.addEventListener("submit", function (event) {
event.preventDefault();
submit();
});
Comment on lines +10 to +13

@cjyuan cjyuan Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider placing all code that runs once on page load in a single function. For example, you could put it inside the page load callback or create a function named init() or setup() and call it once when the page loads.

This makes it easier to locate and manage all the code that runs once when the app starts.


window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
if (myLibrary.length === 0) {
const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);

const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);

myLibrary.push(book1);
myLibrary.push(book2);

render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
const titleValue = titleInput.value.trim();
const authorValue = authorInput.value.trim();
const pagesValue = Number(pagesInput.value);

if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
titleValue === "" ||
authorValue === "" ||
Number.isNaN(pagesValue) ||
pagesValue < 1 ||
!Number.isInteger(pagesValue)
Comment on lines +45 to +47

@cjyuan cjyuan Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these checks is optional (redundant).

@Jacknguyen4438 Jacknguyen4438 Aug 17, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feed back I see that there is better way of doing this validation check I will test this and mesage you back as soon as possible.

) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
alert("Please enter a positive whole number for pages.");
return;
}

const book = new Book(
titleValue,
authorValue,
pagesValue,
readCheckbox.checked
);

myLibrary.push(book);
render();
}

function Book(title, author, pages, check) {
Expand All @@ -51,53 +69,51 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
const tableBody = document.getElementById("book-list");
tableBody.innerHTML = "";

for (let i = 0; i < myLibrary.length; i++) {
const row = tableBody.insertRow();

const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

const readButton = document.createElement("button");
readButton.className = "btn btn-success";

const readStatus = myLibrary[i].check ? "Yes" : "No";

readButton.textContent = readStatus;

readButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
wasReadCell.appendChild(readButton);

const deleteButton = document.createElement("button");

deleteButton.className = "btn btn-warning";
deleteButton.textContent = "Delete";

deleteButton.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;

myLibrary.splice(i, 1);
render();
setTimeout(function () {
alert(`Deleted: ${deletedTitle}`);
}, 0);
});

deleteCell.appendChild(deleteButton);
}
}
Loading