London | 26-ITP-May | Rizqah Popoola | Sprint 3 | Programmer Humour - #561
Open
risikatpopoola wants to merge 1 commit into
Open
London | 26-ITP-May | Rizqah Popoola | Sprint 3 | Programmer Humour#561risikatpopoola wants to merge 1 commit into
risikatpopoola wants to merge 1 commit into
Conversation
risikatpopoola
added
🏕 Priority Mandatory
webmonch
added
Review in progress
webmonch
reviewed
Aug 21, 2026
| comicImage.src = comicImages.img; | ||
| }) | ||
| .catch((error) => { | ||
| console.log("Error fetching image:", error); |
There was a problem hiding this comment.
Will this also catch network errors like 404 or 500?
webmonch
reviewed
Aug 21, 2026
| .then((comicImages) => { | ||
| console.log(comicImages); | ||
| const comicImage = document.getElementById("comic-image"); | ||
| comicImage.src = comicImages.img; |
There was a problem hiding this comment.
Are there any additional properties from returned json we could use to make this image more accessible?
webmonch
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Fetched data from an API endpoint to render images