Skip to content

London | 26-ITP-May | Vito Moratti | Sprint 2 | Book-library #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmoratti wants to merge 19 commits into
base: main
Choose a base branch
from
+227 −149
Open

London | 26-ITP-May | Vito Moratti | Sprint 2 | Book-library #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ee2cff9
fix syntax error on line 57
vmoratti Aug 20, 2026
6bed9db
on line 41 not 'library', 'myLibrary', and 'title.value' is repeated
vmoratti Aug 20, 2026
44d9dea
deleteButton was inconsistent variable, change to deleteBut, change c…
vmoratti Aug 20, 2026
a963df2
add <title> , and lang='en'
vmoratti Aug 20, 2026
3df5e43
fix <meta>, add extra <meta>
vmoratti Aug 20, 2026
50a35c6
add defer to sccript links
vmoratti Aug 20, 2026
08dd57c
add main tag
vmoratti Aug 20, 2026
2073970
add author validation conditions,
vmoratti Aug 20, 2026
8ad6617
change delete button details
vmoratti Aug 20, 2026
e6bd736
Refactor HTML structure and improve form layout
vmoratti Aug 21, 2026
1bb9eae
Change book management and some forms
vmoratti Aug 21, 2026
718d34c
refactor beek-library
vmoratti Aug 21, 2026
16396b5
add styling
vmoratti Aug 21, 2026
ec7bc67
make changes after run through html validator and after general feedback
vmoratti Aug 21, 2026
2f8d0cb
just done merge as something gone wrong
vmoratti Aug 21, 2026
1b1390e
second attempt
vmoratti Aug 21, 2026
7560fea
refactor book handling, and deletion delay
vmoratti Aug 21, 2026
029a35b
change myLibrary variarle as constant to prevent reassignement
vmoratti Aug 21, 2026
415eb6b
addressed some issues
vmoratti Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions debugging/book-library/.vscode/settings.json
View file
Open in desktop

@cjyuan cjyuan Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A common practice is to exclude local configuration files, which typically differ between developers, from a PR branch unless the configuration is required for the changes to work.

To ignore a tracked file such as .vscode/settings.json locally, use:

git update-index --skip-worktree path/to/file

And if you ever need undo the operation in order to track it again, use:

git update-index --no-skip-worktree path/to/file

@vmoratti vmoratti Aug 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, that file snuck in into commit, and i wasn't sure if it's needed to be pushed. So, does it mean that by doing:
git update-index --no-skip-worktree path/to/file
i have undone it now?

@cjyuan cjyuan Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That only tells git not to track the file but the changes made before will still remain on the branch.

For this PR, it's ok to leave it there. You could practice that in future PRs.

@vmoratti vmoratti Aug 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"liveServer.settings.port": 5501
}
190 changes: 114 additions & 76 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,30 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<title>My Book Library</title>
<meta charset="utf-8" />
<meta
name="description"
content="Keep track of the books you've read."
/>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>

<script
src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"
defer
></script>
<script
src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"
defer
></script>
<script
src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"
defer
></script>

<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
Expand All @@ -18,79 +33,102 @@
</head>

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>
<main>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
</div>

<button
data-toggle="collapse"
data-target="#demo"
class="btn btn-info"
aria-expanded="false"
aria-controls="demo"
>
Add new book
</button>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<div id="demo" class="collapse">
<form id="book-form">
<div class="form-group">
<p><span class="text-danger">*</span> Required fields</p>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
<label for="title">
Title:
<span class="text-danger" aria-hidden="true">*</span>
</label>
<input
type="text"
class="form-control"
id="title"
name="title"
required
/>

<label for="author">
Author:
<span class="text-danger" aria-hidden="true">*</span>
</label>
<input
type="text"
class="form-control"
id="author"
name="author"
required
/>

<label for="pages">
Pages:
<span class="text-danger" aria-hidden="true">*</span>
</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
min="1"
step="1"
required
/>

<div class="form-check">
<input
type="checkbox"
class="form-check-input"
id="check"
/>
<label class="form-check-label" for="check">
Read
</label>
</div>

<button
type="submit"
class="btn btn-primary"
>
Submit
</button>
</div>
</form>
</div>
</div>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>
<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>

<tbody>
</tbody>
</table>
</main>

<script src="script.js"></script>
<script defer src="script.js"></script>
</body>
</html>
</html>
Loading
Loading