Skip to content

Cape Town | 26-ITP-May| Enice Mutanda| Sprint 2| Data objects - #1419

Open
Enice-Codes wants to merge 5 commits into
CodeYourFuture:mainfrom
Enice-Codes:Data-Objects
Open

Cape Town | 26-ITP-May| Enice Mutanda| Sprint 2| Data objects#1419
Enice-Codes wants to merge 5 commits into
CodeYourFuture:mainfrom
Enice-Codes:Data-Objects

Conversation

@Enice-Codes

@Enice-Codes Enice-Codes commented Aug 10, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

tested and passed all my code locally
modified the codes
added code to most dependent file
fix codes on certain exercises and implemented code too

@Enice-Codes Enice-Codes added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. javascript Pull requests that update javascript code labels Aug 10, 2026
@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 12, 2026
Poonam-raj
Poonam-raj reviewed Aug 12, 2026
View reviewed changes
Comment thread Sprint-2/implement/lookup.test.js
Poonam-raj
Poonam-raj reviewed Aug 12, 2026
View reviewed changes
Comment thread Sprint-2/implement/tally.test.js Outdated
Poonam-raj
Poonam-raj reviewed Aug 12, 2026
View reviewed changes
Comment thread Sprint-2/implement/tally.test.js Outdated
Poonam-raj
Poonam-raj reviewed Aug 12, 2026
View reviewed changes
Comment thread Sprint-2/implement/tally.test.js Outdated
Poonam-raj
Poonam-raj reviewed Aug 12, 2026
View reviewed changes
Comment thread Sprint-2/interpret/invert.js
Poonam-raj
Poonam-raj reviewed Aug 12, 2026
View reviewed changes
Comment thread Sprint-2/stretch/till.test.js
Poonam-raj
Poonam-raj reviewed Aug 12, 2026
View reviewed changes
Comment thread Sprint-2/stretch/till.js
Poonam-raj
Poonam-raj reviewed Aug 12, 2026
View reviewed changes
Comment thread Sprint-2/stretch/till.js
Poonam-raj
Poonam-raj reviewed Aug 12, 2026
View reviewed changes

@Poonam-raj Poonam-raj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing debug elements here - can you include it in this PR?

I have a few things I'd like you to take another look at, a few answers and explanations are missing. Some tests are also wrong (tally).

Some good logic choices, and methods used.

@Poonam-raj Poonam-raj added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 12, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 14, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 14, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 14, 2026
@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 17, 2026
Poonam-raj
Poonam-raj reviewed Aug 17, 2026
View reviewed changes
Comment thread Sprint-2/interpret/invert.js Outdated
Poonam-raj
Poonam-raj reviewed Aug 17, 2026
View reviewed changes
Comment thread Sprint-2/interpret/invert.js Outdated
Poonam-raj
Poonam-raj reviewed Aug 17, 2026
View reviewed changes
Comment thread Sprint-2/interpret/invert.js Outdated
Poonam-raj
Poonam-raj reviewed Aug 17, 2026
View reviewed changes

@Poonam-raj Poonam-raj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some last bits where your explanation doesn't quite match up

@Poonam-raj Poonam-raj added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 18, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 20, 2026
@Enice-Codes

Enice-Codes commented Aug 21, 2026

Copy link
Copy Markdown
Author

hi @Poonam-raj , I made modifications to the files , the explanations match the logic

@Poonam-raj Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 21, 2026
@Poonam-raj

Poonam-raj commented Aug 21, 2026

Copy link
Copy Markdown

Great edits, thank you for the explanations

@Poonam-raj Poonam-raj added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Poonam-raj Poonam-raj Poonam-raj left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. javascript Pull requests that update javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Enice-Codes @Poonam-raj