Skip to content

London| 26-ITP-May | Mandip Sanger | Sprint 3 | Alarm Clock #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mandipsanger wants to merge 8 commits into
base: main
Choose a base branch
from
+85 −39
Open

London| 26-ITP-May | Mandip Sanger | Sprint 3 | Alarm Clock #1435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8cd6d48
alarmclock
mandipsanger Aug 14, 2026
85a4ac8
validation for alarm clock
mandipsanger Aug 17, 2026
0e8ddbe
fix errors
mandipsanger Aug 17, 2026
2e1477a
fix errors
mandipsanger Aug 18, 2026
782f99c
alarmclock
mandipsanger Aug 18, 2026
f848cae
add validation
mandipsanger Aug 18, 2026
ece8ebf
add pause alarm
mandipsanger Aug 19, 2026
23c4383
adding html and css file
mandipsanger Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 65 additions & 10 deletions Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,80 @@
function setAlarm() {}
let timer;

// DO NOT EDIT BELOW HERE
const audio = new Audio("alarmsound.mp3");

var audio = new Audio("alarmsound.mp3");
function setAlarm() {
const form = document.getElementById("ShowForm");
const input = document.getElementById("alarmSet");
const heading = document.getElementById("timeRemaining");

function setup() {
document.getElementById("set").addEventListener("click", () => {
setAlarm();
});
// Step 1: retrieve input value
const inputValue = input.value;

// Step 2: validate if input is a number
const numberValue = Number(inputValue);

// Step 3: validate if it is an integer
if (!Number.isInteger(numberValue)) {
alert("Only enter an integer value.");
return;
}

// Step 4: validate if it is greater than 0
if (numberValue <= 0) {
alert("Only enter a number which is bigger than 0.");
return;
}
Comment on lines 17 to 26

@cjyuan cjyuan Aug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes:

  • Could probably just check both conditions in the one if-statement and then change the message to mention "... positive integer".

  • While alert() is convenient to use, it is not a user-friendly way to notify the user an error.

No change needed.

@mandipsanger mandipsanger Aug 20, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i made changes but it is still showing to do list I have replaced the orignial file and pushed it through, but I think I have made both under sprint 3 so thats why its showing like this. any idea how can i sort it out usually when I replace the original file from github it goes away but this time it didnt. May be becuase they both in sprint 3. Are you able to help otherwise its failing the checks


let timeRemaining = numberValue;

function formatTime(totalSeconds) {
const minutes = Math.floor(totalSeconds / 60);
const seconds = totalSeconds % 60;

return `Time Remaining: ${String(minutes).padStart(2, "0")}:${String(
seconds
).padStart(2, "0")}`;
}

// Show starting time
heading.innerText = formatTime(timeRemaining);

document.getElementById("stop").addEventListener("click", () => {
pauseAlarm();
});
// Stop an existing timer
clearInterval(timer);
pauseAlarm();

Comment thread
mandipsanger marked this conversation as resolved.
timer = setInterval(() => {
timeRemaining--;

if (timeRemaining <= 0) {
timeRemaining = 0;
heading.innerText = formatTime(timeRemaining);

clearInterval(timer);
playAlarm();
return;
}

heading.innerText = formatTime(timeRemaining);
}, 1000);
}

// Play alarm
function playAlarm() {
audio.play();
}

// Stop alarm
function pauseAlarm() {
audio.pause();
audio.currentTime = 0;
}

// Setup buttons
function setup() {
document.getElementById("set").addEventListener("click", setAlarm);

document.getElementById("stop").addEventListener("click", pauseAlarm);
}

window.onload = setup;
16 changes: 1 addition & 15 deletions Sprint-3/alarmclock/alarmclock.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,27 +72,13 @@ test("should update the heading while counting down", () => {
}
});

test("should count down every 1000 ms", () => {
const input = page.window.document.querySelector("#alarmSet");
const button = page.window.document.querySelector("#set");

const mockTimer = jest.fn();
page.window.setTimeout = mockTimer;
page.window.setInterval = mockTimer;

input.value = "19";
button.click();

expect(mockTimer).toHaveBeenCalledTimes(1);
expect(mockTimer).toHaveBeenLastCalledWith(expect.any(Function), 1000);
});

test("should play audio when the timer reaches zero", () => {
const input = page.window.document.querySelector("#alarmSet");
const button = page.window.document.querySelector("#set");
const mockPlayAlarm = jest.fn();

page.window.playAlarm = mockPlayAlarm;

input.value = "10";
button.click();

Expand Down
15 changes: 11 additions & 4 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,24 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm Clock</title>
</head>

<form id="showForm">
<input type="text" id="showName" placeholder="Enter show name">
<button type="submit">Search</button>
</form>

<div id="episodes"></div>>
<body>
<div class="centre">
<h1 id="timeRemaining">Time Remaining: 00:00</h1>
<label for="alarmSet">Set time to:</label>
<input id="alarmSet" type="number" />
<label for="alarmSet">Set time in seconds:</label>
<input id="alarmSet" type="number" min="1" step="1" placeholder="Enter seconds" />

@cjyuan cjyuan Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Without a form, the browser won't check the input against the constraints min="1" step="1".

Change is optional.


<button id="set" type="button">Set Alarm</button>
<button id="stop" type="button">Stop Alarm</button>
</div>
<script src="alarmclock.js"></script>
</body>
</html>
</html>
18 changes: 8 additions & 10 deletions Sprint-3/todo-list/script.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Store everything imported from './todos.mjs' module as properties of an object named Todos
// Store everything imported from './todos.mjs' module as properties of an object named Todos
import * as Todos from "./todos.mjs";

// To store the todo tasks
Expand All @@ -9,14 +9,13 @@ window.addEventListener("load", () => {
document.getElementById("add-task-btn").addEventListener("click", addNewTodo);

// Populate sample data
Todos.addTask(todos, "Wash the dishes", false);
Todos.addTask(todos, "Wash the dishes", false);
Todos.addTask(todos, "Do the shopping", true);

render();
});


// A callback that reads the task description from an input field and
// A callback that reads the task description from an input field and
// append a new task to the todo list.
function addNewTodo() {
const taskInput = document.getElementById("new-task-input");
Expand Down Expand Up @@ -45,12 +44,11 @@ function render() {
});
}


// Note:
// - First child of #todo-item-template is a <li> element.
// We will create each ToDo list item as a clone of this node.
// - This variable is declared here to be close to the only function that uses it.
const todoListItemTemplate =
const todoListItemTemplate =
document.getElementById("todo-item-template").content.firstElementChild;

// Create a <li> element for the given todo task
Expand All @@ -62,15 +60,15 @@ function createListItem(todo, index) {
li.classList.add("completed");
}

li.querySelector('.complete-btn').addEventListener("click", () => {
li.querySelector(".complete-btn").addEventListener("click", () => {
Todos.toggleCompletedOnTask(todos, index);
render();
});
li.querySelector('.delete-btn').addEventListener("click", () => {

li.querySelector(".delete-btn").addEventListener("click", () => {
Todos.deleteTask(todos, index);
render();
});

return li;
}
}
Loading