Karla Grajales | Module-Data-Groups | Sprint-3 Quote Generator App

[Grajales-K]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

I’ve learned to manipulate the DOM by creating and appending elements like buttons and divs. I implemented a random quote generator, handled events to display new quotes and control auto-quotes, and added background sound functionality with the Audio mp3, enriching the user experience. 🔊

Questions

Ask any questions you have for your reviewer.

[cjyuan]

When I loaded the app using Live Server on my computer, I see these errors in the browser's JS console:

The URL of the page (as shown in my browser) is http://127.0.0.1:5500/index.html.

Can you fix these two bugs?

[cjyuan]

Chrome browser also shows this error:
Uncaught (in promise) NotAllowedError: play() failed because the user didn't interact with the document first. https://goo.gl/xX8pDD

This is also the first time I am aware of it. Just thought you might be interested to know.
You do not have to fix it. If you want to fix the issue, you can do it after you have completed this PR first.

[Grajales-K]

Chrome browser also shows this error: Uncaught (in promise) NotAllowedError: play() failed because the user didn't interact with the document first. https://goo.gl/xX8pDD

This is also the first time I am aware of it. Just thought you might be interested to know. You do not have to fix it. If you want to fix the issue, you can do it after you have completed this PR first.

Thank you for the article @cjyuan I saw yesterday that the audio needs to have a displayed button where to mute or replay. Read more thank you for sharing this. I have to look into it.

[Grajales-K]

When I loaded the app using Live Server on my computer, I see these errors in the browser's JS console:

The URL of the page (as shown in my browser) is http://127.0.0.1:5500/index.html.

Can you fix these two bugs?

Thank you, @cjyuan. I removed the script in the HTML to fix the error. I moved the media to the assets folder relative to the root directory. I can not see the error with the image on my side. Thank you for your quick response.

[Grajales-K]

Chrome browser also shows this error: Uncaught (in promise) NotAllowedError: play() failed because the user didn't interact with the document first. https://goo.gl/xX8pDD
This is also the first time I am aware of it. Just thought you might be interested to know. You do not have to fix it. If you want to fix the issue, you can do it after you have completed this PR first.

Thank you for the article @cjyuan I saw yesterday that the audio needs to have a displayed button where to mute or replay. Read more thank you for sharing this. I have to look into it.

[Grajales-K]

[cjyuan]

I just suggested a way to fix the image URL problem. Feel free to mark this PR as completed anytime.

[cjyuan]

Instead of using an absolute path, it is better to use a path "relative to style.css".