London | ITP-May-2025 | Hibo Sharif | Sprint 3 | Todo_list by hibosharif202504 · Pull Request #702 · CodeYourFuture/Module-Data-Groups

hibosharif202504 · 2025-07-25T11:56:10Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

I have implemented the populateTodoList() function to loop through the given list of todos. For each todo, I created a list element and added the appropriate text and action icons. The function now dynamically adds each todo item to the page, matching the structure in index.html.
I added a button that allows users to delete all completed ToDos with a single click. When clicked, the button triggers a function that loops through the list of ToDos and removes any that are marked as completed. The undo button makes it easy for users to clean up their list and keep it organised.
I also implemented an Undo button that restores the most recently deleted completed ToDos. When a user clicks "Delete All Completed," the removed items are stored temporarily. Clicking "Undo" then brings them back to the list. This feature adds flexibility and prevents the accidental loss of essential Todo items.

Questions

Ask any questions you have for your reviewer.

MattGoodwin0 · 2025-08-11T18:35:01Z

Really great submission! Very well organised and hitting the brief well - a few comments to take the code to the next level!

MattGoodwin0 · 2025-08-11T14:20:01Z

Sprint-3/todo-list/index.html

+
+      <div class=" container">
+        <h1> Todo List</h1>
+        <form class=""add-todo-form>


This is a small issue on the form element

Thank you for the review @MattGoodwin0 . I have made the change.

MattGoodwin0 · 2025-08-11T14:22:58Z

Sprint-3/todo-list/index.html

+        <input type="text"  id="new-todo-input" placeholder="New todo..." />
+        <button type="submit" class="add-btn">Add Todo</button>
+      </form>
+        <button onclick="deleteAllCompletedTodos()" class="delete-all-btn">Delete All Completed</button>


These two button implement their interaction functionality differently - is there a reason for this?
One uses the class and the other onclick.

MattGoodwin0 · 2025-08-11T14:27:21Z

Sprint-3/todo-list/script.js

  event.preventDefault();
  // Write your code here... and remember to reset the input field to be blank after creating a todo!
+
+  let input =


With the HTML fix you can probably look to simplify this.

Hi @MattGoodwin0 ,

I have updated the code.

MattGoodwin0 · 2025-08-11T18:34:12Z

Sprint-3/todo-list/script.js

+  todos.forEach((todo, index) => {
+    // create the todo elements
+    const listItem = document.createElement("li"); // create list item
+    listItem.className = todo.completed ? "todo-item completed" : "todo-item";


Can you think of a way we could reduce this logic?

Could a compound selector be used here to reduce the javascript code.

Let me know if this isn't part of the sprint!

MattGoodwin0 · 2025-08-11T18:34:17Z

Sprint-3/todo-list/script.js

+    listItem.className = todo.completed ? "todo-item completed" : "todo-item";
+
+    let todoText = document.createElement("span");
+    todoText.className = todo.completed ? "todo-text completed" : "todo-text";


same as above - Can you think of a way we could reduce this logic?

Could a compound selector be used here to reduce the javascript code.

Let me know if this isn't part of the sprint!

github-actions · 2025-08-14T07:44:47Z

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Sprint part (Module-Data-Group) doesn't match expected format (example: 'Sprint 2', without quotes)

github-actions · 2025-08-16T09:40:49Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Module-Data-Group) doesn't match expected format (example: 'Sprint 2', without quotes)

github-actions · 2025-08-16T10:25:48Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

Implemented the to-do list

c8d51d3

hibosharif202504 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 25, 2025

hibosharif202504 mentioned this pull request Jul 25, 2025

[TECH ED] Build todo-list app hibosharif202504/My-Coursework-Planner#82

Open

5 tasks

MattGoodwin0 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 5, 2025

MattGoodwin0 self-requested a review August 6, 2025 14:15

MattGoodwin0 suggested changes Aug 11, 2025

View reviewed changes

MattGoodwin0 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 11, 2025

[Hibo Sharif] added 4 commits August 12, 2025 22:37

Updated the index.html file

d3502bf

I have reduced the code in line 13

ee464b2

I have updated the code in line 16

915340d

Simplified the code in line 66

36b438b

hibosharif202504 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 12, 2025

MattGoodwin0 removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 14, 2025

illicitonion closed this Sep 1, 2025

Uh oh!

Conversation

hibosharif202504 commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

MattGoodwin0 commented Aug 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 16, 2025

Uh oh!

github-actions bot commented Aug 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hibosharif202504 commented Jul 25, 2025 •

edited

Loading