Glasgow | May-2025 | Mansoor Munawar | Sprint 2

[MansoorM11]

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.
I completed the exercises for sprint-2 which included degbugging programs, implementing function and test based on set requirement, and leaving comments detailing program execution and where the bug is located within the program.

Questions

Ask any questions you have for your reviewer.

[LonMcGregor]

Good work - I just have spotted one possible issue in your contains exercise

[LonMcGregor]

What happens if you pass it some input like contains([1,2,3,4], "length") - remember one of your test specifications says it should give false when passed an array

[MansoorM11]

I saw that it returns true because arrays in Javascript has own length property. I managed to refactor my code to take this into account and now it returns false. Thanks

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[LonMcGregor]

This change solves this issue. When implementing things like this in the future, make sure you understand what the program specification is asking for. Here you added a condition that specifically checks for arrays and the property "length". Try re-reading the specification in the test file for that task - can you see how you could improve your implementation?

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[MansoorM11]

I understood the requirement, but I didn’t realise that arrays are treated like objects and their indices are used as keys. That’s something new I learned today. Thanks! So now the updated code will return false for an array as a parameter.

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[LonMcGregor]

Great! You are now done with this sprint, you can close the PR now

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s