London | 25-ITP-May | Houssam Lahlah | Sprint 3 | Quote Generator

[HoussamLh]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

What I did

1. Updated index.html title to "Quote generator app".
2. Added logic in quotes.js to show a random quote and author when the page loads.
3. Implemented "New Quote" button functionality to display a new random quote.
4. Styled the app (style.css) with:
5. Yellow background page.
6. White centered frame container.
7. Yellow button with white text.
8. Quotes styled with a yellow “ symbol before the text.

Challenges I faced

• Making sure the “ symbol stays on the same line with the quote text, while also being styled larger than the quote itself.
• My approach was to wrap the symbol in a and apply CSS (vertical-align, margin-right).
• It not works, and I tried to wrap the symbol in a
  but not works as well and I’m not sure if this is the best practice.

Questions

• I know I can’t edit under the // DO NOT EDIT BELOW HERE comment in quotes.js, so I injected the symbol before each quote in the display logic.

[cjyuan]

Code looks good. I don't have anything to add.