Skip to content

West Midlands | ITP-Sep-25 | Baba Yusuf | Sprint 1 | Module-data-groups/Sprint-1#870

Closed
Baba05206 wants to merge 8 commits intoCodeYourFuture:mainfrom
Baba05206:module-data-groups/sprint-1
Closed

West Midlands | ITP-Sep-25 | Baba Yusuf | Sprint 1 | Module-data-groups/Sprint-1#870
Baba05206 wants to merge 8 commits intoCodeYourFuture:mainfrom
Baba05206:module-data-groups/sprint-1

Conversation

@Baba05206
Copy link

@Baba05206 Baba05206 commented Nov 21, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR contains the completest tasks for Sprint-1. Tasks: Fix, Implement & Refactor have been completed.

@Baba05206 Baba05206 changed the title West Midlands | Baba | Yusuf | Sprint 1 | Module-data-groups/Sprint-1 West Midlands | Baba Yusuf | Sprint 1 | Module-data-groups/Sprint-1 Nov 21, 2025
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Baba05206 Baba05206 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Nov 21, 2025
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 21, 2025
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Baba05206 Baba05206 changed the title West Midlands | Baba Yusuf | Sprint 1 | Module-data-groups/Sprint-1 West Midlands | ITP-Sep-25 | Baba Yusuf | Sprint 1 | Module-data-groups/Sprint-1 Nov 21, 2025
@Baba05206 Baba05206 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 21, 2025
@tenzyns tenzyns added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 21, 2025
tenzyns
tenzyns reviewed Nov 30, 2025
View reviewed changes
Sprint-1/refactor/includes.js
for (let index = 0; index < list.length; index++) {
const element = list[index];
for (const element of list) {
if (element === target) {
Copy link

@tenzyns tenzyns Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the test pass for this? This doesn't seem to return false in any case. And a test case is expecting a false.

@tenzyns
Copy link

tenzyns commented Nov 30, 2025

Very well written. Just one comment on the refactor/include.js file.

@tenzyns tenzyns added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 30, 2025
@Baba05206 Baba05206 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 7, 2025
@Baba05206
Copy link
Author

Baba05206 commented Dec 13, 2025

@tenzyns , may I ask for your feedback on the updated response please? Thank you.

@tenzyns tenzyns added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 16, 2025
@tenzyns
Copy link

tenzyns commented Dec 16, 2025

Looks good. ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tenzyns tenzyns tenzyns left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Baba05206 @tenzyns @illicitonion