West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 3 | Alarm Clock by Baba05206 · Pull Request #900 · CodeYourFuture/Module-Data-Groups

Baba05206 · 2025-11-30T17:39:06Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I implemented the setAlarm() function as per instruction

Set Alarm sets Time Remaining to the MM:SS equivalent of the user input in field 'Set time to'
The function decrements Time Remaining: every second i.e. counted down by 1 sec
When Time Remaining: reaches 00:00, the alarm plays a sound.
Stop Alarm stops the alarm sound being played
Checked for update to the testing framework by running npm install
Updated the title in the index.html file as per task instruction
and then...
I tried to change branch name but got it all wrong
and then i tried again a

Questions

github-actions · 2025-11-30T17:39:19Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-30T17:39:50Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-30T17:39:51Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-30T17:39:53Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-30T17:43:49Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Baba05206 · 2025-11-30T17:45:34Z

@cjyuan , i need some help here. You already reviewed and commented on my first submission. I made several errors in attempting to change the branch name hence the multiple submissions and all the errors. May I ask for your help to walk me through how to deal with this sort of scenario in the future?

github-actions · 2025-11-30T17:57:32Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

cjyuan · 2025-11-30T19:41:08Z

Feel free to DM me on Slack if you would like to arrangement an online meeting with me.

If you don't have any questions to ask, you should delete the "Questions" section or change the default text in the "Questions" section in the PR description. Otherwise the bot will remove the "Needs review" label.

bp7968h · 2025-12-03T01:07:59Z

Sprint-3/alarmclock/index.html

When the user first sees this field, how would he know what to input is it minute, second, hours?, and also think about the screen readers, give as much as context to the user programmatically as well as visually.

I have used a representative name totalSeconds to show input is in seconds.

@Baba05206 I think the original comment is about improving accessibility in the HTML code.

Can you try sharing your HTML code to an AI, ask it how you can improve its accessibility, and then update your code accordingly?

bp7968h · 2025-12-03T01:09:22Z

Sprint-3/alarmclock/alarmclock.js


+function setAlarm() {
+  const input = document.getElementById("alarmSet");
+  let time = Number(input.value);


Is the variable readable, time (is it hour, minute, second, milliseconds)?

now, i believe it is. i had thought it did, but now certainly does. thanks

bp7968h · 2025-12-03T01:11:03Z

Sprint-3/alarmclock/alarmclock.js


+function setAlarm() {
+  const input = document.getElementById("alarmSet");
+  let time = Number(input.value);


What if the user inputs -1?

will review, update based on the above comments and revert by tomorrow morning. many thanks for for your guidance.

bp7968h · 2025-12-03T01:13:42Z

Sprint-3/alarmclock/alarmclock.js

+  function format(num) {
+    if (num < 10) return "0" + num;
+    return num;
+  }


This is nice way to pad number, is there any predefined methods?

... i have now changed to code to use padStart instead of format()

bp7968h · 2025-12-03T01:14:51Z

Sprint-3/alarmclock/alarmclock.js

+      format(Math.floor(time / 60)) +
+      ":" +
+      format(time % 60);
+  }, 1000);


These 60 and 1000 are magic numbers, is there better way to handle magic numbers?

Replaced magic numbers with named constants that explains their purpose.

bp7968h · 2025-12-03T01:15:51Z

Sprint-3/alarmclock/alarmclock.js

+    format(Math.floor(time / 60)) +
+    ":" +
+    format(time % 60);


You are repeating this twice in your code, how would you increase efficiency if you needed to change something in the future?

I can hold the value in/as a variable so I can call the variable without having to repeat an expression or an existing value.

To cater for invalid entry (include negative values), I am now implemented a form of input validation to ensure the user enters a valid positive number.

Hi @Baba05206 , wouldn't it be easy to create a utility function, that takes arguments like time and then the return value is the string with formatted time and second, and then you can just call this function where you need!

…plication

Baba05206 · 2025-12-13T10:15:43Z

@cjyuan , may I ask for your feedback on the updated response please? Thank you.

cjyuan

I think you have addressed all comments (except the improving the accessibility in HTML part) by @bp7968h.

In addition to improving accessibility, can you also address my two new comments?

cjyuan · 2025-12-13T13:06:21Z

Sprint-3/alarmclock/alarmclock.js

+  const heading = document.getElementById("timeRemaining");
+
+  let totalSeconds = Number(input.value);
+
+  // Input validation: check for invalid or non-positive numbers
+  if (isNaN(totalSeconds) || totalSeconds <= 0) {
+    heading.innerText = "Please enter a valid positive number of seconds";
+    return;
+  }


Some input that can mess up the clock display can still pass this check.

Sprint-3/alarmclock/alarmclock.js

…nt invalid inputs and reset clock when new input is accepted

cjyuan

Changes look good.

Just a few more suggestions. No change required.

cjyuan · 2025-12-13T20:31:15Z

Sprint-3/alarmclock/alarmclock.js

+  // Reset any existing countdown
+  clearInterval(intervalId);


Could consider placing all the "resetting" code together (code on lines 54 and 28).

cjyuan · 2025-12-13T20:38:40Z

Sprint-3/alarmclock/index.html

+      <h1 id="timeRemaining" aria-live="polite" role="timer">
+        Time Remaining: 00:00
+      </h1>


Could consider express code on lines 12-14 as:

<div id="timeRemaining" aria-live="polite" role="timer"> Time Remaining: <span id="theTime">00:00</span> </div>

Note: Use AI to find out why if needed.

cjyuan · 2025-12-13T20:49:32Z

Sprint-3/alarmclock/alarmclock.js

+
+  // Prevent extremely large or zero values
+  if (totalSeconds === 0 || totalSeconds > 86400) {
+    heading.innerText = "Time Remaining: 00:00";


The same time-update code shows up in multiple places, which is a good signal that it could be factored into a utility function.

cjyuan · 2025-12-13T20:57:26Z

Sprint-3/alarmclock/alarmclock.js

+  // STRONG VALIDATION: must be digits only
+  if (!/^\d+$/.test(raw)) {
+    heading.innerText = "Time Remaining: 00:00";
+    errorMsg.textContent =
+      "Invalid input. Please enter a whole number of seconds (e.g., 10, 30, 120). Decimals and text are not allowed.";
+    return;
+  }
+
+  let totalSeconds = Number(raw);
+
+  // Prevent extremely large or zero values
+  if (totalSeconds === 0 || totalSeconds > 86400) {


Could consider combining these two checks into:

let totalSeconds = Number(raw); if (!Number.isInteger(totalSeconds) || totalSeconds <= 0 || totalSeconds > 86400) { errorMsg.textContent = "Please enter an integer between 1 and 86400"; return; }

Baba05206 and others added 6 commits November 6, 2025 18:05

Add initial implementation of mean calculation and tests

11e30f5

Refactor mean calculation and tests for clarity and functionality

3cb29a0

Update mean.js

3d4c407

Implement alarm functionality and update title in HTML

b235bd1

Remove unnecessary blank line in setAlarm function

a4fcc54

deleted prep

5aa6e97

Baba05206 added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Nov 30, 2025

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 30, 2025

Baba05206 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 30, 2025

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 30, 2025

Merge branch 'CodeYourFuture:main' into alarm-clock

80cc2eb

Baba05206 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 30, 2025

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 30, 2025

Baba05206 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 30, 2025

bp7968h suggested changes Dec 3, 2025

View reviewed changes

bp7968h added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 3, 2025

Updated code to reflected all 6 improvements recommended

50a0653

Baba05206 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 7, 2025

bp7968h removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 11, 2025

Refactor - Added formatTimeDisplay utility function to reduce code du…

9a76928

…plication

Baba05206 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 11, 2025

cjyuan reviewed Dec 13, 2025

View reviewed changes

cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 13, 2025

refactored code as per the 3 comments to improve accessibility, preve…

6948ee0

…nt invalid inputs and reset clock when new input is accepted

Baba05206 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 13, 2025

cjyuan reviewed Dec 13, 2025

View reviewed changes

Baba05206 mentioned this pull request Dec 17, 2025

25-ITP-Sep | Data groups | Baba Yusuf Baba05206/My-Coursework-Planner-BY#80

Open

illicitonion closed this Jan 7, 2026

Uh oh!

Conversation

Baba05206 commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

Baba05206 commented Nov 30, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

cjyuan commented Nov 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Baba05206 Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Baba05206 Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Baba05206 commented Dec 13, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Baba05206 commented Nov 30, 2025 •

edited

Loading

Baba05206 Dec 7, 2025 •

edited

Loading

Baba05206 Dec 7, 2025 •

edited

Loading