West Midlands | 25-ITP-Sept | Mustaf Asani | Sprint 3 | Feature/alarmclock#921
Closed
asaniDev wants to merge 15 commits intoCodeYourFuture:mainfrom
Closed
West Midlands | 25-ITP-Sept | Mustaf Asani | Sprint 3 | Feature/alarmclock#921asaniDev wants to merge 15 commits intoCodeYourFuture:mainfrom
asaniDev wants to merge 15 commits intoCodeYourFuture:mainfrom
Conversation
asaniDev
added
Needs Review
cjyuan
reviewed
Dec 9, 2025
cjyuan
added
Reviewed
asaniDev
added
the
Needs Review
cjyuan
reviewed
Dec 16, 2025
Sprint-3/alarmclock/alarmclock.js
Outdated
Comment on lines
17
to
20
| if (timer) { | ||
| clearInterval(timer); | ||
| timer = null; | ||
| } |
Contributor
There was a problem hiding this comment.
You may also want to stop the alarm (to reset all application states before starting a new countdown)
Author
There was a problem hiding this comment.
added code to stop the alarm if it was playing
Sprint-3/alarmclock/alarmclock.js
Outdated
| clearInterval(timer); | ||
| timer = null; | ||
| } | ||
| timer = setInterval(countDown, 1000); |
Contributor
There was a problem hiding this comment.
Line 20 will still get executed even when inputTime is 0.
cjyuan
removed
the
Needs Review
asaniDev
added
the
Needs Review
cjyuan
reviewed
Dec 17, 2025
Comment on lines
11
to
30
| if (inputTime === 10) { | ||
| changeBgColor = true; | ||
| } else if (inputTime === 0) { | ||
| displayTime(inputTime); | ||
| playAlarm(); | ||
| document.querySelector("#alarmSet").reset(); | ||
| } | ||
| displayTime(inputTime); | ||
| if (typeof audio !== "undefined" && audio) { | ||
| audio.pause(); | ||
| try { | ||
| audio.currentTime = 0; | ||
| } catch (e) {} | ||
| audio.loop = false; // disable looping if it was set | ||
| } | ||
| if (timer) { | ||
| clearInterval(timer); | ||
| } | ||
| timer = setInterval(countDown, 1000); | ||
| } |
Contributor
There was a problem hiding this comment.
When inputTime is 0, can you identify all the code between line 11 and 30 that will be executed? And among them, which code are unnecessarily executed?
Consider organising the code in the following maner:
// Step 1: Reset everything (timer, audio, background, ...) before starting a new countdown
// Note: Can also consider implement a function to reset everything and then call the function here
...
// Step 2; Validate input
...
// Step 3: Start a new countdown depending on the value of `inputTime`
...
cjyuan
reviewed
Dec 20, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks much cleaner now.
| } | ||
|
|
||
| displayTime(inputTime); | ||
| timer = setInterval(countDown, 1000); |
Contributor
There was a problem hiding this comment.
Does the app need to execute the code on line 20 when inputTime is 0?
Can you figure out what would happen when line 20 is executed when inputTime is 0? Even though the side-effect is almost unnoticeable, it is important we (as a programmer) recognise what our code do exactly.
cjyuan
removed
the
Needs Review
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Added functions to alarm to make the timer count down from input time and alarm to off when it reaches 0.