London | 25-ITP-Sept | Samuel Tarawally | Sprint 3 | Alarm Clock by Tarawally · Pull Request #929 · CodeYourFuture/Module-Data-Groups

Tarawally · 2025-12-13T03:26:04Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Implemented countdown timer displaying time in mm:ss format
Added alarm sound and flashing red background when timer reaches zero
Enabled stop button to pause alarm and remove visual effects

github-actions · 2025-12-13T03:26:17Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

cjyuan · 2025-12-13T11:52:40Z

Sprint-3/alarmclock/alarmclock.js

+  let formattedMinutes = `${minutes}`;
+  if (minutes < 10) {
+    formattedMinutes = `0${minutes}`;
+  }
+
+  let formattedSeconds = `${seconds}`;
+  if (seconds < 10) {
+    formattedSeconds = `0${seconds}`;
+  }
+
+  return `Time Remaining: ${formattedMinutes}:${formattedSeconds}`;


Code on lines 13-23 could be simplified by using String.prototype.padStart().

cjyuan · 2025-12-13T11:55:45Z

Sprint-3/alarmclock/alarmclock.js

+ * Updates the display and checks if the alarm should sound.
+ */
+function updateTime() {
+  const titleElement = document.getElementById("timeRemaining");


We could perform the operation on line 30 only once and reuse the retrieved DOM element repeatedly (to improve performance).

cjyuan · 2025-12-13T12:00:13Z

Sprint-3/alarmclock/alarmclock.js

+ * Initialises the alarm countdown.
+ */
+function setAlarm() {
+  if (alarmTimerIdentifier) {


Once set, alarmTimerIdentifier is never reset. So this condition will only be false the first time setAlarm() is called. Well, do we need to check or reset this variable?

The variable needs to be reset otherwise the condition will always be true after the first alarm.

cjyuan · 2025-12-13T12:08:29Z

Sprint-3/alarmclock/alarmclock.js

+  const titleElement = document.getElementById("timeRemaining");
+  titleElement.innerText = formatTime(timeRemainingInSeconds);


These two statements and the statements on lines 30, 33 are identical. This is usually a hint that we could factor out the code into a function, and then just call the function to perform the corresponding task.

cjyuan · 2025-12-13T12:11:15Z

Sprint-3/alarmclock/alarmclock.js

+  alarmTimerIdentifier = setInterval(() => {
+    updateTime();
+  }, ONE_SECOND_IN_MILLISECONDS);
+}


The alarm will sound one second afterward when the input is either 0 or 1 second -- it is a bit inconsistent. Can you improve the consistency?

I'll add a conditional statement to handle this case.

Tarawally · 2025-12-15T22:56:06Z

I have refactored the code to address the points:

Replaced manual zero padding with String.prototype.padStart().
Cached timeRemaining globally to avoid repeated DOM queries.
Reset alarmTimerIdentifier to null after clearing the interval.
Extracted display logic into a reusable displayTime() function.
Added immediate handling for the 0 second edge case.

cjyuan

Changes look good.

cjyuan · 2025-12-16T10:09:35Z

Sprint-3/alarmclock/alarmclock.js

+ */
+function setAlarm() {
+  if (alarmTimerIdentifier) {
+    clearInterval(alarmTimerIdentifier);


If this function returns on line 56, 60, or 75, alarmTimerIdentifier will remain unchanged even though the corresponding interval is cleared here.

Tarawally added 6 commits December 13, 2025 03:24

feat: update structure and layout for alarm clock

c3824f3

feat: implement digital clock design

3a0ada8

feat: implement alarm clock logic with set, update and stop functions

c964595

refactor: improving comments for clarity and readability

895d8c6

style: revert to standard basic ui layout

1aff7c8

feat: implement core functionality and UI enhancements

f08fbfc

Tarawally changed the title ~~Feat/alarmclock~~ London | 25-ITP-Sept | Samuel Tarawally | Sprint 3 | Alarm Clock Dec 13, 2025

Tarawally added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 13, 2025

cjyuan reviewed Dec 13, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 13, 2025

Tarawally added 5 commits December 15, 2025 20:43

refactor: simplify time formatting with padStart

7342082

fix: reset timer identifier after alarm completes

8f1a667

refactor: extract display update logic into separate function

fbc7a56

fix: handle zero-second alarm edge case

548ef16

fix: correct timer logic and prevent multiple intervals

426f1fb

Tarawally added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 15, 2025

cjyuan reviewed Dec 16, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 16, 2025

illicitonion closed this Jan 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

London | 25-ITP-Sept | Samuel Tarawally | Sprint 3 | Alarm Clock#929

London | 25-ITP-Sept | Samuel Tarawally | Sprint 3 | Alarm Clock#929
Tarawally wants to merge 11 commits intoCodeYourFuture:mainfrom
Tarawally:feat/alarmclock

Tarawally commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

cjyuan Dec 13, 2025

Uh oh!

cjyuan Dec 13, 2025

Uh oh!

cjyuan Dec 13, 2025

Uh oh!

Tarawally Dec 15, 2025

Uh oh!

cjyuan Dec 13, 2025

Uh oh!

cjyuan Dec 13, 2025

Uh oh!

Tarawally Dec 15, 2025

Uh oh!

Tarawally commented Dec 15, 2025

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		const titleElement = document.getElementById("timeRemaining");
		titleElement.innerText = formatTime(timeRemainingInSeconds);

Uh oh!

Conversation

Tarawally commented Dec 13, 2025

Learners, PR Template

Changelist

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tarawally commented Dec 15, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants