West Midlands | ITP-Sept-25 | Mustaf Asani | Sprint 2 | Data groups coursework

[asaniDev]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Completed the debug, implement and interpret tasks

[cjyuan]

You are doing great. tally.js could still use some improvement.

[cjyuan]

itemCount is used only inside the while loop, so it is best practice to declare the variable here (in the block { ... } where the variable is being used)

[cjyuan]

Can your code work without using tempArray?

[asaniDev]

i realised the danger of nested while loops that rely on internally changing variables, when i changed to remove tempArray as its value was no longer being used, I came across an endless loop as my original one was relying on taking out items from inputArray to give an exit condition. I refactored my code to use an iterator to count the frequency of each item without mutating inputArray.

[cjyuan]

Is this check necessary? Under what circumstances will itemCount be 0 or less?

[cjyuan]

The previous solution was not as efficient but it was a good opportunity to practice using nested loops.

I will go ahead and approve this PR first, you can improve your solution later.

[cjyuan]

Does the following function call returns the value you expect?

tally(["toString", "toString"]);

Suggestion: Look up an approach to create an empty object with no inherited properties.