Skip to content

London | 26 ITP May | Sayeed Hussain | Sprint 1 | Form Control - #1230

Closed
sayeedhussain01 wants to merge 6 commits into
CodeYourFuture:mainfrom
sayeedhussain01:form-control
Closed

London | 26 ITP May | Sayeed Hussain | Sprint 1 | Form Control#1230
sayeedhussain01 wants to merge 6 commits into
CodeYourFuture:mainfrom
sayeedhussain01:form-control

Conversation

@sayeedhussain01

@sayeedhussain01 sayeedhussain01 commented May 6, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have updated all input and select options .Also, I validated all html Elements with a validator and checked accessibility with lighthouse.

@netlify

netlify Bot commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2c7682a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69fb9d4a4e55a50008576304
😎 Deploy Preview https://deploy-preview-1230--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sayeedhussain01 sayeedhussain01 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels May 6, 2026
@Sambuxc Sambuxc added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 13, 2026
Sambuxc
Sambuxc reviewed May 13, 2026
View reviewed changes
Comment thread Form-Controls/index.html
<link rel="stylesheet" href="style.css">
</head>

<body class="font">

@Sambuxc Sambuxc May 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this class font to its styles to the body element?

@sayeedhussain01 sayeedhussain01 May 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not strictly necessary for body element ,but I added it to ensure consistent font styling across the entire page.

Sambuxc
Sambuxc reviewed May 13, 2026
View reviewed changes
Comment thread Form-Controls/index.html
<!-- This is a size option -->

<div>
<label class="blk" for="sz"> T-shirt Size*</label>

@Sambuxc Sambuxc May 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to avoid heavily abbreviated class names as it takes away the meaning and makes it difficult for other developers to understand. Let me know if you dont understand what I mean and I can clarify with you on slack.

@sayeedhussain01 sayeedhussain01 May 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand it.
Thank you

Sambuxc
Sambuxc reviewed May 13, 2026
View reviewed changes
Comment thread Form-Controls/style.css


/* This is a whole form's class */
.form{

@Sambuxc Sambuxc May 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what styles here are specific to the form element?

@sayeedhussain01 sayeedhussain01 May 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved whole form in the middle of the page .

Sambuxc
Sambuxc approved these changes May 13, 2026
View reviewed changes

@Sambuxc Sambuxc left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, I have left some questions for you that aren't blockers but more to get you thinking.
Well done :)

@Sambuxc Sambuxc added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 13, 2026
@sayeedhussain01 sayeedhussain01 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 5, 2026
@cjyuan

cjyuan commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@Sambuxc Since you have approved the PR, I am labelling this PR "Complete" on your behalf.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 9, 2026
@cjyuan

cjyuan commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@sayeedhussain01

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@sayeedhussain01 sayeedhussain01 mentioned this pull request Jun 10, 2026
Open
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Sambuxc Sambuxc Sambuxc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sayeedhussain01 @cjyuan @illicitonion @Sambuxc