London | May 2026 | Giorgi Natriashvili | Sprint 1 | Form Controls - #1250
Closed
Giontr wants to merge 4 commits into
Closed
London | May 2026 | Giorgi Natriashvili | Sprint 1 | Form Controls#1250Giontr wants to merge 4 commits into
Giontr wants to merge 4 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Giontr
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Giontr
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Giontr
added
📅 Sprint 1
Sambuxc
approved these changes
May 12, 2026
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <h1>Verify your order </h1> |
There was a problem hiding this comment.
for next time, watch out for stray spacing.
the h1 element has a single space at the start of the line
Sambuxc
added
Complete
Contributor
|
@Sambuxc I noticed that you approved the change but the label still indicates that you are still in the process of reviewing this PR. In CYF courses, instead of the normal PR process, we only use label to indicates the state of a PR.
May I know what is the status of this PR? |
|
@cjyuan thanks for clarification on that. This PR is completed. |
cjyuan
added
Complete
Contributor
|
Thanks for clarification. I just changed the label to "Complete" on your behalf. |
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I built simple forms for verifying order for client, after change styles in CSS for "radio" buttons to meet accessibility criteria, however realized that whole form needed some margin for spacing, which was changed afterwards.
Finally I met accessibility criteria 100.