Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Form Control - #1310
Closed
Motorcycle-lab wants to merge 6 commits into
Closed
Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Form Control #1310Motorcycle-lab wants to merge 6 commits into
Motorcycle-lab wants to merge 6 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Motorcycle-lab
added
📅 Sprint 1
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
May 19, 2026
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <label for="user-name">Your Name:</label> | ||
| <input id="user-name" name="user-name" type="text" pattern="[A-Za-z\s\-]{2,}" title="Please enter at least 2 letters. Numbers and symbols are not allowed" required> |
Contributor
There was a problem hiding this comment.
Pattern validation works for 2 or more names - good work
Poonam-raj
reviewed
May 19, 2026
|
|
||
| <label for="colors">Choose your favorite color:</label> | ||
| <select id="colors" name="colour" required> | ||
| <option value="" disabled selected>Select a color...</option> |
Contributor
There was a problem hiding this comment.
nice choice to disable the first option
Poonam-raj
reviewed
May 19, 2026
| <option value="xxl">XXL</option> | ||
| </select> | ||
|
|
||
| <button id="go" type="submit"> Submit |
Contributor
There was a problem hiding this comment.
I reckon the ID attribute could be something relating to the action like 'form-submit'
Poonam-raj
reviewed
May 19, 2026
Poonam-raj
left a comment
Poonam-raj
left a comment
Contributor
There was a problem hiding this comment.
Accessibility is 100 ✅
Thank you for cleaning up this branch so it only contains form controls work 🎉
Great work - fulfilling the requirements, only one suggestion about the id of the submit button but this work is complete overall
Poonam-raj
added
Complete
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Change list
I have put the button before the closing tag.
I have added a name
I have changed my branch of main into a different branch of form control to prevent polluting into the main branch in the future.
Questions
I am just correcting the code based on feedback.