London | May2026 | Mahbubur Rahman | Sprint 2 | Wireframe - #1321
Closed
mahbubur13 wants to merge 10 commits into
Closed
London | May2026 | Mahbubur Rahman | Sprint 2 | Wireframe#1321mahbubur13 wants to merge 10 commits into
mahbubur13 wants to merge 10 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mahbubur13
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
May 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this task, see my comments where you can improve further
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <img src="wireframe.png" alt="" /> |
There was a problem hiding this comment.
If the image provides more information than is available in the text it is usually a good idea to offer a brief description in the alt property. Do you think that is needed here?
|
|
||
|
|
||
| </main> | ||
| <footer> |
There was a problem hiding this comment.
The footer is correctly fixed to the bottom of the viewport, but as you scroll, do you notice it overlaps the page? Can you improve the readability when this happens?
LonMcGregor
added
Reviewed
mahbubur13
added
Needs Review
If you can fix these, the task will be done.You are very close! |
LonMcGregor
added
Reviewed
Author
I have updated the footer as requested |
|
Thanks, this task is completed now |
LonMcGregor
added
Complete
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have completed the wireframe task in sprint 2