Glasgow | ITP-May-2026 | Craig Stoddart | Sprint 2 | Wireframe to Web Code - #1343
Closed
CraigStodd wants to merge 14 commits into
Closed
Glasgow | ITP-May-2026 | Craig Stoddart | Sprint 2 | Wireframe to Web Code #1343CraigStodd wants to merge 14 commits into
CraigStodd wants to merge 14 commits into
Conversation
-Changed header to "Wireframe To Web Code" -Changed description to: "Wireframes, README & Git branches, explained."
… duplicate headings to "README" + "Git Branches," respectively. "Wireframe" article: - img: Replaced "placeholder.svg" with "wireframe.png," added alt description. - <p>: removed default text; added explanation of wireframes. -<a>: added hyperlink to figma.com article on wireframes.
"README" article: -Replaced "placeholder.svg" with "README-File-Example.jpg;" added alt. description. - <p>: Replaced default text with explanation of README files -Added <ul>
-Added image: "CYF-Git-Branch-Example.png" "Git Branches" article: -Deleted default <p> text; added explanation of Git Branches -Added hyperlink to "Read more" <a> tag
- Capitalised "READ MORE" - Cleaned up formatting of <a> tags and text CSS: - :root : Updated --line to "2px solid" - header: removed all properties, added property: "text-align: center" - footer: removed: "display: flex," "align-items," "justify-content;" added: "text-align: center" - a: added: "text-decoration: none," "color: black" - article: removed: "align-items: center"
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CraigStodd
added
the
Needs Review
LonMcGregor
reviewed
May 30, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this task. Great explanations for each topic.
Some git tips: You don't need to include so much detail in the Pull request description. Your commits have all the detail, so it's fine to give a high level summary
To answer your question: You're using a grid layout within each article. Is there a grid alignment property you could use? https://css-tricks.com/complete-guide-css-grid-layout/ has a nice overview of different alignment options
| </main> | ||
|
|
||
| <footer> | ||
| <p> |
There was a problem hiding this comment.
The footer is meant to be "fixed to viewport" - do you know what this means and how to achieve it?
LonMcGregor
added
Reviewed
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEARNERS, PR TEMPLATE
Self checklist
Changelist
HTML:
CSS:
Base Elements section:
: root {}:
--line: 1px solid;a {}:
font-family: Arial; font-weight: 600; text-decoration: none; color: black;img, svg {}:
margin: auto;Added: "Text Formatting" section.
font-family: 'Franklin Gothic Medium', 'Arial Narrow', Arial, sans-serif;font-family: 'Gill Sans', 'Gill Sans MT', Calibri, 'Trebuchet MS', sans-serif;Site Layout section:
Added: Header{} selector.
text-align: center;Footer{}:
position: fixed; bottom: 0;font-weight: 700; border-top-style: solid;Articles Grid Layout section:
1.Fixed parsing error- moved:
main > *:first-child { grid-column: span 2; }outside ofmain{}Article Layout section:
article > * { grid-column: 2/3; }outside ofarticle{}article > img { grid-column: span 3; }outside ofarticle{}Questions
The content in the bottom-right article is proportioned differently - the image doesn't reach the top of the article box and the "Read More" button is shaped differently. I was unable to fix this and get it looking consistent with other articles. What could I do to fix this?