Skip to content

London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Wireframe - #1364

Closed
russom-g wants to merge 23 commits into
CodeYourFuture:mainfrom
russom-g:feature/wireframe
Closed

London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Wireframe#1364
russom-g wants to merge 23 commits into
CodeYourFuture:mainfrom
russom-g:feature/wireframe

Conversation

@russom-g

@russom-g russom-g commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the [style guide]

Changelist

Based on the wireframe I wrote a webpage explaining README file, wireframe and branch git.

russom added 14 commits May 21, 2026 22:16
@netlify

netlify Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 7beccbb
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a1afb0f42b6080008f20528
😎 Deploy Preview https://deploy-preview-1364--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 97 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
2 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@russom-g russom-g added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
@russom-g russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 30, 2026
cjyuan
cjyuan reviewed May 30, 2026
View reviewed changes

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is free of errors and well formatted. Page layout is solid. I only have one comment.

Comment thread Wireframe/index.html Outdated
<article>
<img src="placeholder.svg" alt="" />
<h2>Title</h2>
<img src="images/README.png" alt="" />

@cjyuan cjyuan May 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images
fail to load, giving users essential context about the content or function of the image.

Can you give a more descriptive alt value to all images?

@russom-g russom-g May 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to review my code. I have now added more alt descriptive texts to all the images. Thanks

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 30, 2026
@cjyuan

cjyuan commented May 30, 2026

Copy link
Copy Markdown
Contributor

Changes look good. Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 30, 2026
@russom-g russom-g mentioned this pull request May 31, 2026
Open
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@russom-g @cjyuan @illicitonion