Manchester | 26-ITP-May | Abdu Hassen | Sprint 2 | wireframe - #1366
Manchester | 26-ITP-May | Abdu Hassen | Sprint 2 | wireframe #1366Abduhasen wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code is error free and well formatted. Page layout is strong. Well done.
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
-
The unordered list in the "Changelist" section of the PR description is not correctly formatted in Markdown. Can you fix it?
… to one and also changed the position of footer in to fixed.
Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:
|
…it does't overlap with the article content
|
First of all, I would like to say thank you for your
constructive feedback. It always helps a lot to develop and to have more
understanding on that matter, and also to view it in a more advanced way. I
am always glad to get feedback from mentors like you. Thank you!
…On Tue, 2 Jun 2026 at 02:15, CJ Yuan ***@***.***> wrote:
*cjyuan* left a comment (CodeYourFuture/Module-Onboarding#1366)
<https://github.com/CodeYourFuture/Module-Onboarding/pull/1366#issuecomment-4597835995>
- Currently the footer content and the article content could overlap.
Can you prevent it from happening?
image.png (view on web)
<https://github.com/user-attachments/assets/23bda3d1-3454-41ce-b61f-0f554d24d1d1>
------------------------------
Please note that in CYF courses, the recommended way to inform the
reviewer of your changes is to do both of the following:
- *Reply to their feedback.*
- In the responses, clarify how each piece of feedback was
addressed to demonstrate that you've carefully reviewed the suggestions.
- You may find the suggestions in this PR Guide
<https://programming.codeyourfuture.io/guides/reviewing/trainee-pr-guide/#addressing-reviewer-feedback>
useful.
- Your response may trigger a notification (depending on the
reviewer's settings), helping ensure they’re aware of the updates you’ve
made.
- *Replace the "Reviewed" label by a "Needs review" label* (which you
have done -- great!)
- Without this label, the reviewer would not know if your changes
is ready to be reviewed.
—
Reply to this email directly, view it on GitHub
<https://github.com/CodeYourFuture/Module-Onboarding/pull/1366?email_source=notifications&email_token=BXXD2ULT2UV3EXCOV4ZPS4D45YTBRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJZG44DGNJZHE22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4597835995>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXXD2UIMZPBUNJD2PONFL6T45YTBRAVCNFSM6AAAAACZSLJLKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKOJXHAZTKOJZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Changes look good. Well done. |
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |


… to the article
Learners, PR Template
Self checklist
Changelist
Questions
N/A