London | 26-ITP-May | Martin Mwaka | Sprint 1 | Form Controls - #1369
London | 26-ITP-May | Martin Mwaka | Sprint 1 | Form Controls#1369Temceo wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
Code is error free and well formatted. Form is well structured. Well done.
| </body> | ||
| </html> | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Can you look up why keeping trailing empty lines (blank lines at the end of a files) is generally considered poor practice in repositories?
Formatting tool such as prettier can often help us get rid of them automatically.
As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |

Self checklist
Changelist
I have forked the original form controls and made updates on a branch (sprint1_control_forms).
I have add a new form using semantic html with labels and controls for entry of name, email, colour and sizes