Skip to content

London | May ITP | Martim Lou | Sprint 1 | Form-Controls - #1406

Closed
MartimLou42 wants to merge 3 commits into
CodeYourFuture:mainfrom
MartimLou42:martim-form
Closed

London | May ITP | Martim Lou | Sprint 1 | Form-Controls#1406
MartimLou42 wants to merge 3 commits into
CodeYourFuture:mainfrom
MartimLou42:martim-form

Conversation

@MartimLou42

@MartimLou42 MartimLou42 commented Jun 3, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Added required form fields for name and email
  • Added colour and size controls for the T-shirt order
  • Grouped form controls with fieldsets and legends for semantic HTML

@netlify

netlify Bot commented Jun 3, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 386c32a
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a20321ab73c8900084d3363
😎 Deploy Preview https://deploy-preview-1406--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@MartimLou42 MartimLou42 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@MartimLou42 MartimLou42 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is error free and well formatted. All requirements met. Well done!

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 4, 2026
@illicitonion

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants