London | ITP-May-2026 | Carolina Villa | Sprint 2 | Wireframe Task - #1443
Closed
caro-vh wants to merge 21 commits into
Closed
London | ITP-May-2026 | Carolina Villa | Sprint 2 | Wireframe Task#1443caro-vh wants to merge 21 commits into
caro-vh wants to merge 21 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
caro-vh
added
📅 Sprint 2
cjyuan
removed
Needs Review
cjyuan
reviewed
Jun 11, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Code is error-free and well formatted. Page layout matches the wireframe well.
Can you assign different URLs to the "Read more" links to meet one of the requirements:
The articles section contains three distinct articles, each with its own unique image, title, summary, and link.
cjyuan
added
the
Reviewed
Contributor
|
On separate notes,
Changelistinstead of just bolded text like this? ## Changelist
|
caro-vh
added
the
Needs Review
Author
|
Thanks, I have now fixed it. |
Contributor
|
What about the links mentioned in this comment: https://github.com/CodeYourFuture/Module-Onboarding/pull/1443#pullrequestreview-4478645509 ? |
cjyuan
removed
the
Needs Review
caro-vh
added
the
Needs Review
Author
|
Hi, links added. |
Contributor
|
All good. |
cjyuan
added
Complete
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Used the provided wireframe and resources to write a new webpage that explains the purpose of README files, wireframes and what a brnach is.
Questions
No questions