Skip to content

Re-fill overview page, and error if it's empty - #1266

Merged
illicitonion merged 3 commits into
mainfrom
empty-overview-error
Dec 27, 2024
Merged

Re-fill overview page, and error if it's empty#1266
illicitonion merged 3 commits into
mainfrom
empty-overview-error

Conversation

@illicitonion

@illicitonion illicitonion commented Dec 27, 2024

Copy link
Copy Markdown
Member

@SallyMcGrath it looks like in #1241 you removed all of the modules from the programming menu... Was this intentional? The overview page is currently being driven by that - can we either change what menu the overview page is driven from, or re-add the programming menu?

@netlify

netlify Bot commented Dec 27, 2024

Copy link
Copy Markdown

Deploy Preview for cyf-curriculum canceled.

Name Link
🔨 Latest commit e3c7c10
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/676e868989bcbb00088ceb91

@netlify

netlify Bot commented Dec 27, 2024

Copy link
Copy Markdown

Deploy Preview for cyf-launch ready!

Name Link
🔨 Latest commit e3c7c10
🔍 Latest deploy log https://app.netlify.com/sites/cyf-launch/deploys/676e8689720962000887fce4
😎 Deploy Preview https://deploy-preview-1266--cyf-launch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Dec 27, 2024

Copy link
Copy Markdown

Deploy Preview for cyf-sdc ready!

Name Link
🔨 Latest commit e3c7c10
🔍 Latest deploy log https://app.netlify.com/sites/cyf-sdc/deploys/676e868909e7bc000855ec75
😎 Deploy Preview https://deploy-preview-1266--cyf-sdc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Dec 27, 2024

Copy link
Copy Markdown

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit e3c7c10
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/676e8689f8bdaf00084a9049
😎 Deploy Preview https://deploy-preview-1266--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Dec 27, 2024

Copy link
Copy Markdown

Deploy Preview for cyf-common ready!

Name Link
🔨 Latest commit e3c7c10
🔍 Latest deploy log https://app.netlify.com/sites/cyf-common/deploys/676e86894a5816000883eb0f
😎 Deploy Preview https://deploy-preview-1266--cyf-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Dec 27, 2024

Copy link
Copy Markdown

Deploy Preview for cyf-tracks ready!

Name Link
🔨 Latest commit e3c7c10
🔍 Latest deploy log https://app.netlify.com/sites/cyf-tracks/deploys/676e8689afe8d50008e8c968
😎 Deploy Preview https://deploy-preview-1266--cyf-tracks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Dec 27, 2024

Copy link
Copy Markdown

Deploy Preview for cyf-itd ready!

Name Link
🔨 Latest commit e3c7c10
🔍 Latest deploy log https://app.netlify.com/sites/cyf-itd/deploys/676e86892c5c3e00084abf05
😎 Deploy Preview https://deploy-preview-1266--cyf-itd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify

netlify Bot commented Dec 27, 2024

Copy link
Copy Markdown

Deploy Preview for cyf-piscine ready!

Name Link
🔨 Latest commit e3c7c10
🔍 Latest deploy log https://app.netlify.com/sites/cyf-piscine/deploys/676e8689ca061e00083c96a1
😎 Deploy Preview https://deploy-preview-1266--cyf-piscine.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@illicitonion illicitonion changed the title Error if overview page is empty Re-fill overview page, and error if it's empty Dec 27, 2024
@illicitonion

Copy link
Copy Markdown
Member Author

Merging because I'm all alone today and this seems unfortunately and accidentally broken

@illicitonion
illicitonion merged commit 6cc635f into main Dec 27, 2024
@illicitonion
illicitonion deleted the empty-overview-error branch December 27, 2024 11:01
@SallyMcGrath

Copy link
Copy Markdown
Member

Merging because I'm all alone today and this seems unfortunately and accidentally broken

Oh, hm, sorry I failed to commit that change to overview. I did intentionally change the name of the menu to be clearer based on feedback from the community and I EVEN checked the overview still worked (and briefly considered logging a warning on empty pages) but I didn't commit the file or check it on the deployed preview. I am sorry!

I will write logging in now. Thanks for catching this!

@SallyMcGrath

Copy link
Copy Markdown
Member

Merging because I'm all alone today and this seems unfortunately and accidentally broken

Oh, hm, sorry I failed to commit that change to overview. I did intentionally change the name of the menu to be clearer based on feedback from the community and I EVEN checked the overview still worked (and briefly considered logging a warning on empty pages) but I didn't commit the file or check it on the deployed preview. I am sorry!

I will write logging in now. Thanks for catching this!

Oh and you have done that too. TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants