Skip to content

traditonal chinese readme addition(HK +TW) - #1282

Open
jason1015-coder wants to merge 1 commit into
CodebuffAI:mainfrom
jason1015-coder:main
Open

traditonal chinese readme addition(HK +TW)#1282
jason1015-coder wants to merge 1 commit into
CodebuffAI:mainfrom
jason1015-coder:main

Conversation

@jason1015-coder

Copy link
Copy Markdown

added traditional Chinese addition (for both speaking region variants--Hong Kong and Taiwan

@codebuff-team

Copy link
Copy Markdown
Contributor

Thanks for putting effort into localization — a Traditional Chinese README is a reasonable ask given the existing zh-CN one, and the translation itself reads as competent, fluent Chinese, not machine-mangled filler.

A few concerns that would need addressing before this is portable:

  1. HK and TW variants are nearly identical. Diffing README.zh-HK.md and README.zh-TW.md shows only a handful of word-choice differences (本地/本機, 發佈/發布, 儲存庫 wording, etc.). That's a lot of duplicated content (224 lines) to maintain for marginal variation. A single README.zh-TW.md covering both Taiwan and Hong Kong usage (as is common practice) would be far easier to keep in sync, or note the few HK-specific terms inline instead of forking the whole file.

  2. Generated data-use block. Both new files include a <!-- BEGIN GENERATED FREEBUFF DATA USE --> section, which in the main README is presumably auto-generated/templated from source data, not meant to be hand-translated and pasted. If that block changes upstream (model list, policy wording), these two new files will silently drift out of sync with no mechanism to catch it. Worth checking with maintainers how that section is generated before duplicating it by hand.

  3. Missing trailing newline on both new files (\ No newline at end of file) — minor, but the repo's other README files end cleanly.

  4. Given this is a squashed mirror, this specific PR's diff would need porting by hand — the duplication above makes that porting more error-prone and higher maintenance cost than the value added. Consolidating to one zh-TW file (or confirming with maintainers that HK deserves separate treatment) would make this much more likely to land.

@codebuff-team codebuff-team added bot:triaged Classified by the community triage bot pr:needs-work Right idea, not mergeable as written labels Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:triaged Classified by the community triage bot pr:needs-work Right idea, not mergeable as written

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants