Skip to content

Enhance tests for assertCompleteAxiomResponse #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gugu8intel-i9 wants to merge 1 commit into
base: main
Choose a base branch
from
+31 −4
Open

Enhance tests for assertCompleteAxiomResponse #1302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions common/src/util/__tests__/axiom-complete-response.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,39 @@ describe('isCompleteAxiomResponse', () => {
})

describe('assertCompleteAxiomResponse', () => {
test('names the caller in the error', () => {
expect(() =>
assertCompleteAxiomResponse({ status: { isPartial: true } }, 'hour 12'),
).toThrow(/^hour 12: Axiom returned a partial or statusless answer/)
test('does not throw for a complete response', () => {
expect(() =>
assertCompleteAxiomResponse({ status: { isPartial: false } }, 'hour 12'),
).not.toThrow()
})

test('throws for a partial response with the caller name', () => {
expect(() =>
assertCompleteAxiomResponse({ status: { isPartial: true } }, 'hour 12'),
).toThrow(/^hour 12: Axiom returned a partial or statusless answer$/)
})

test('throws for a statusless response — not just partials', () => {
expect(() =>
assertCompleteAxiomResponse({ buckets: { totals: [] } }, 'hour 12'),
).toThrow(/^hour 12: Axiom returned a partial or statusless answer$/)

expect(() =>
assertCompleteAxiomResponse({ status: {} }, 'hour 12'),
).toThrow(/^hour 12: Axiom returned a partial or statusless answer$/)

expect(() =>
assertCompleteAxiomResponse({ status: null }, 'hour 12'),
).toThrow(/^hour 12: Axiom returned a partial or statusless answer$/)
})

test('throws for non-object inputs', () => {
expect(() =>
assertCompleteAxiomResponse(null, 'hour 12'),
).toThrow(/^hour 12: Axiom returned a partial or statusless answer$/)

expect(() =>
assertCompleteAxiomResponse(undefined, 'hour 12'),
).toThrow(/^hour 12: Axiom returned a partial or statusless answer$/)
})
})
Loading