Ensure settings is an array#1235
Open
girishpanchal30 wants to merge 2 commits into
Open
Conversation
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
girishpanchal30
force-pushed
the
bugfix/1232
branch
from
13db7fc to
ff57ea1
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent PHP 8.1+ deprecation warnings caused by writing into $settings[...] when $settings is false (due to feedzy_get_settings filters returning non-arrays), by normalizing $settings to an array before assigning nested keys.
Changes:
- Adds an
is_array()guard to ensure$settingsis an array prior to settinggeneraltab options.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Plugin build for 6f475ae is ready 🛎️!
Note You can preview the changes in the Playground |
girishpanchal30
changed the title
Soare-Robert-Daniel
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate that the settings are an array to prevent automatic conversion of false to an array in PHP 8.1+, which causes deprecation warnings.
Check before Pull Request is ready:
Closes #1232