fix: reject cyclic serialized chart data in decode_content()#1345
Merged
Soare-Robert-Daniel merged 1 commit intoJul 16, 2026
Conversation
Ports the contains_references() guard from Visualizer Pro (#600) into the free plugin. unserialize() with allowed_classes=false blocks object injection but not references, so a self-referential serialized array survived and drove strip_incomplete_objects() into unbounded recursion (memory/stack exhaustion DoS) on any render/export/clone path. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
pirate-bot
added
the
pr-checklist-complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the
contains_references()guard from Visualizer Pro (Codeinwp/visualizer-pro#600) into the free plugin.unserialize()withallowed_classes => falseblocks object injection but not references, so a self-referential serialized array survived decoding and drovestrip_incomplete_objects()into unbounded recursion — a memory/stack-exhaustion DoS reachable from any render/export/clone path.decode_content()now walks the decoded value withReflectionReference::fromArrayElement()(PHP 7.4+, matching the plugin's declared minimum) and returnsfalsewhen any array element is a reference. Cyclic structures necessarily contain a reference, and rejecting all references also prevents shared references from becoming cycles later.Will affect visual aspect of the product
NO
Test instructions
vendor/bin/phpunit --filter Test_Security_Object_Injection— a cyclic serialized array is rejected bydecode_content()instead of recursing.Check before Pull Request is ready:
🤖 Generated with Claude Code