Skip to content

fix down/negative scroll again Hopefully #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Raltyro merged 1 commit into from
Aug 4, 2026
+8 −7
Merged

fix down/negative scroll again Hopefully #1043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions source/funkin/game/Note.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ class Note extends FlxSprite
return v;
}
inline function get_useAntialiasingFix() {
return gapFix>0;
return gapFix > 0;
}

/**
Expand Down Expand Up @@ -288,14 +288,15 @@ class Note extends FlxSprite

@:noCompletion @:dox(hide) override function isOnScreen(?camera:FlxCamera):Bool {
var downscrollCam = (Std.isOfType(camera, HudCamera) ? cast(camera, HudCamera).downscroll : false);

if (updateFlipY) {
flipY = (isSustainNote && flipSustain) && (downscrollCam != (lastScrollSpeed < 0));
}
if (downscrollCam == __lastDownscrollCam)
return super.isOnScreen(camera);
else
__lastX = x;

if (updateFlipY) flipY = (isSustainNote && flipSustain) && (downscrollCam != (__strum != null && __strum.getScrollSpeed(this) < 0));
if (downscrollCam && __strum != null) {
if (downscrollCam && __strum != null && __strum.updateNotesPosX && updateNotesPosX) {
x = -x + 2 * (__strum.x - origin.x + offset.x) + __strum.width;
}
final isOnScreen = super.isOnScreen(camera);
Expand All @@ -312,7 +313,7 @@ class Note extends FlxSprite
}

public function isOnScreenOriginal(?camera:FlxCamera):Bool {
return super.isOnScreen(camera);
return super.isOnScreen(camera);
}

public var earlyPressWindow:Float = Flags.EARLY_HIT_WINDOW_RANGE;
Expand All @@ -324,7 +325,7 @@ class Note extends FlxSprite
if (lastScrollSpeed != scrollSpeed) {
lastScrollSpeed = scrollSpeed;
if (nextSustain != null) {
scale.y = (sustainLength * 0.45 * scrollSpeed) / frameHeight;
scale.y = (sustainLength * 0.45 * Math.abs(scrollSpeed)) / frameHeight;
updateHitbox();
scale.y += gapFix / frameHeight;
}
Expand All @@ -334,7 +335,7 @@ class Note extends FlxSprite
}

public function updateSustainClip() if (wasGoodHit && !noSustainClip) {
var t = CoolUtil.bound((Conductor.songPosition - strumTime) / height * 0.45 * lastScrollSpeed, 0, 1);
var t = CoolUtil.bound((Conductor.songPosition - strumTime) / height * 0.45 * Math.abs(lastScrollSpeed), 0, 1);
@:bypassAccessor {
if (clipRect == null) clipRect = FlxRect.get();
clipRect.set(0, frameHeight * t, frameWidth, frameHeight * (1 - t));
Expand Down