Repository navigation
fix: harden plugin directory recovery - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
menuentry-point path instead of assumingQOpen.qmllives at the plugin rootfile://entry-point URLs before constructing a local backend pathentryPointstooWhy
PR #14 fixed catalog loading after
__sourceDirwas stripped, but the first fallback assumed the menu entry point always lived directly in the plugin root. A future move such asui/QOpen.qmlwould therefore resolvebackendPathunderui/bin/qopen.Omarchy v4.0.3 already contains
publicPluginManifest()sanitization and the scopedPluginRegistryApi, so the previous 4.0.4+ compatibility note was also one release too high.Verification
CI should run the existing backend/unit suite and QML syntax compilation. The previous source-level assertions remain compatible, and the new tests specifically guard full entry-point stripping and local-file URL validation.